Fix Java Access Bridge compatibility on 32 bit systems #16557

FelipeZanabria · 2024-05-16T17:55:08Z

Link to issue number:

Summary of the issue:

When NVDA focuses a Java application on a 32-bit system, it gets stuck on the icon, without the ability to interact with it.

Description of user facing changes

When the user on a 32-bit system focuses on a Java application, the controls can be navigated normally, as was the case in version 2019.2.1 and earlier.

Description of development approach

Check the architecture of the running system
Based on this define the jobj64 class.
- If the system is 64 bits use the type c_int64, otherwise use c_int.
- Finally define which dll should be loaded. If the system is 64-bit, load WindowsAccessBridge-32.dll included in NVDA, otherwise load WindowsAccessBridge.dll, available in c:\Windows\System32.

Testing strategy:

Assuming the user has Java installed on a 32-bit system, simply search for Java in the start menu or control panel. When you find the configure Java element, press enter and move through it

Known issues with pull request:

None.

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

AppVeyorBot · 2024-05-16T18:33:37Z

PASS: Translation comments check.
PASS: Unit tests.
FAIL: Lint check. See test results for more information.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/4gyqqk370bur9hv6/artifacts/output/nvda_snapshot_pr16557-31953,3d1837b1.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.2,
INSTALL_END 1.0,
BUILD_START 0.0,
BUILD_END 31.7,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 2.4,
FINISH_END 0.2

See test results for failed build of commit 3d1837b138

AppVeyorBot · 2024-05-16T23:48:31Z

FAIL: Lint check. See test results for more information.
CI timing (mins):
INIT 0.0,
INSTALL_START 1.0,
INSTALL_END 0.9,
BUILD_START 0.0,
BUILD_END 29.6,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 2.3,
FINISH_END 0.2
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/17vhgbbd9osfsybb/artifacts/output/nvda_snapshot_pr16557-31955,833372aa.exe
PASS: Translation comments check.
PASS: Unit tests.

See test results for failed build of commit 833372aadc

seanbudd · 2024-05-17T02:23:18Z

source/JABHandler.py

@@ -43,6 +44,9 @@
 import config
 from utils.security import isRunningOnSecureDesktop

+#: Verification of the architecture of the running system
+is_64Bit = maxsize > 2**32


given #16330, could you make this a system wide constant in winAPI.constants?

See also #16330 (comment), please use os.environ["PROCESSOR_ARCHITECTURE"].endswith("64")

source/JABHandler.py

user_docs/en/changes.md

Co-authored-by: Sean Budd <[email protected]>

mwhapples · 2024-05-17T06:45:46Z

What environment precisely is this other DLL to be used in? To clarify specifically what I am thinking, is it for a 32-bit OS environment where both NVDA and the Java runtime will be 32-bit, or is it for a 32-bit (java runtime regardless of the OS environment (IE. it is possible to run a 32-bit JRE on a 64-bit OS). Does this correctly detect the actual thing of concern or does it miss a case IE. if the DLL is to be used whenever a 32-bit JRE application is running, then detecting the OS architecture misses the case of 32-bit JRE on 64-bit windows). Can NVDA detect whether the application is a 32-bit or 64-bit process?

…ystems in an NVDA lib folder. The way of checking the system's architecture has also been modified for better readability.

AppVeyorBot · 2024-05-17T07:32:59Z

PASS: Translation comments check.
PASS: Unit tests.
FAIL: Lint check. See test results for more information.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/spkk5koadevgnhwq/artifacts/output/nvda_snapshot_pr16557-31973,95b6ced4.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.2,
INSTALL_END 1.0,
BUILD_START 0.0,
BUILD_END 31.7,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 2.4,
FINISH_END 0.2

See test results for failed build of commit 95b6ced447

FelipeZanabria · 2024-05-17T17:06:53Z

What environment precisely is this other DLL to be used in? To clarify specifically what I am thinking, is it for a 32-bit OS environment where both NVDA and the Java runtime will be 32-bit?

Yes.

FelipeZanabria · 2024-05-17T21:31:46Z

See nvaccess/javaAccessBridge32-bin#2

seanbudd · 2024-05-21T05:43:14Z

source/JABHandler.py

@@ -43,6 +43,9 @@
 import config
 from utils.security import isRunningOnSecureDesktop

+#: Verification of the architecture of the running system
+is_64Bit = os.environ["PROCESSOR_ARCHITECTURE"].endswith("64")


As requested earlier, given #16330, could you make this a system wide constant in winAPI.constants?

source/JABHandler.py

josephsl · 2024-05-21T14:50:40Z

Hi, if you want to know system architecture, do NOT use “PROCESSOR_ARCHITECTURE” environment variable as it will , if yoㅕsystem architecture, 애 NOT use PROCESSOR_ARCHITECTURE environment variable as it returns whatever the architecture is set for the current process only. In addition to making this an API constant, a much better method is winVersion.getWinVer().processorArchitecture.endswith(“64”), and this call will be useful for a while as we move toward 64-bit NVDA (see #16304). Thanks.

seanbudd · 2024-05-22T01:51:35Z

Thanks @FelipeZanabria, can you please pull in the latest changes from nvaccess/javaAccessBridge32-bin#2 and also update

nvda/projectDocs/dev/createDevEnvironment.md

Line 86 in e7e8233

    
           * [Java Access Bridge 32 bit, from Zulu Community OpenJDK build 17.0.9+8Zulu (17.46.19)](https://github.com/nvaccess/javaAccessBridge32-bin)

seanbudd · 2024-05-22T01:52:13Z

Please also add a message to changes.md like this one

nvda/user_docs/en/changes.md

Line 205 in 57ce236

* Updated Java Access Bridge to 17.0.9+8Zulu (17.46.19). (#15744)

josephsl · 2024-05-27T03:46:25Z

Hi Felipe,

I see. Thanks for the pull request, and please do use Windows 10 or 11 yourself while writing the next pull request.

Thakns.

Adriani90 · 2024-05-27T19:26:11Z

@mwhapples have you any chance to test this PR on some 32bit java applications on 32 / 64 bit systems?

At least on my Windows 11 on a 64 bit system it works well with the 64bit java configuration window which indicates that the java access bridge for 64 bit works aas expected, so this PR doesn't seem to have any effect on 64 bit.
So if we can test that for 32bit works as well, then I guess it should be fine.

Adriani90 · 2024-05-27T19:33:22Z

I also tested with JRE 8.411 32bit, it still works fine on my 64 bit system.

So I think we need here testing on pure 32 bit systems I guess.

@FelipeZanabria do you have a test application we can test with? Or can you give some recommendations?

FelipeZanabria · 2024-05-27T21:53:08Z

I also tested with JRE 8.411 32bit, it still works fine on my 64 bit system.

So I think we need here testing on pure 32 bit systems I guess.

@FelipeZanabria do you have a test application we can test with? Or can you give some recommendations?

@Adriani90 Thanks for trying and commenting.
The Java control panel itself is enough, although I also tried the Linux sampler for Windows 32-bit.
https://download.linuxsampler.org/packages/win32/snapshots/linuxsampler_20240326_setup.exe
The installer covers both architectures, so you must have a 32-bit system for x32 to be installed. In the components to be installed, you must check Jsampler, which is the Java frontend application.

seanbudd · 2024-05-29T05:47:48Z

I don't have it, but I'm going to write to the mailing list in Spanish inviting them to try the changes.

@FelipeZanabria - can you link to this thread?
When we get testing confirmed with a 32bit system I think we can merge

FelipeZanabria · 2024-05-29T22:01:47Z

Here is the thread:
https://groups.google.com/g/nvda-es/c/2JwIUPg_Lo0
And:
https://groups.google.com/g/nvda-es/c/pko9MwD8b8s

FelipeZanabria · 2024-05-31T23:08:59Z

@seanbudd it seems that no one on the Spanish mailing list uses 32-bit Windows, except for one who also uses w7, which doesn't help moving forward.
Perhaps you could ask on the international mailing list.
What do you think? Could someone do it? Thank you.

seanbudd · 2024-06-03T01:07:28Z

@FelipeZanabria - could you send a message to the mailing list?

FelipeZanabria · 2024-06-03T02:04:44Z

I didn't want to subscribe just for that, but I'm going to find it and do this.

FelipeZanabria · 2024-06-05T23:10:08Z

I didn't get an ansuer on the international list either. Even the moderators put a note warning against replying in the group, since almost no one has 32-bit hardware. The recommendation was that they write to me privately. No one has done this either.
What do you think about it? Should this be closed without implementing the changes? Should another PR be opened just to update constants.py with IS_64BIT?

seanbudd · 2024-06-07T02:21:33Z

I think unfortunately we will just leave this as blocked until testing can be done, and close eventually if none can be done

seanbudd · 2024-06-07T02:22:59Z

@ivnc you reported on #10842 that you could reproduce the issue on Windows 10. Can you test that this fix works for you?

seanbudd · 2024-06-07T02:23:14Z

@FelipeZanabria feel free to open a separate PR to handle #16330

wmhn1872265132 · 2024-06-07T06:13:02Z

Tested according to the Testing strategy on a 32-bit virtual machine, and it is in line with expectations.

FelipeZanabria · 2024-06-07T22:02:17Z

Tested according to the Testing strategy on a 32-bit virtual machine, and it is in line with expectations.

Maybe it is not necessary to create another PR.

ivnc · 2024-06-09T17:00:32Z

@ivnc you reported on #10842 that you could reproduce the issue on Windows 10. Can you test that this fix works for you?

Yes, we had an user who reported this in Windows 10. I've just located that ticket, let me contact him and will report back as soon as he replies.
Thanks.

seanbudd · 2024-06-26T00:28:35Z

@ivnc - any updates on testing the build out?

Thanks for reaching out

ivnc · 2024-07-07T01:41:19Z

No, so far there has been no response, I've just contacted the user again. Hopefully there'll be one soon, I keep you updated.

seanbudd · 2024-07-15T02:55:34Z

@FelipeZanabria - could you resolve merge conflicts?

seanbudd · 2024-09-01T23:53:01Z

Closing as abandoned

Fixed Java Access Bridge compatibility on 32 bit systems

df2bff0

FelipeZanabria requested a review from a team as a code owner May 16, 2024 17:55

FelipeZanabria requested a review from gerald-hartig May 16, 2024 17:55

Update JABHandler.py to fix Lint test errors

2a64785

FelipeZanabria added 2 commits May 16, 2024 21:02

Updated Changes.md to include the Java Access Bridge fix

11229e5

Fix more Lint issues

82cf4c9

seanbudd mentioned this pull request May 17, 2024

Runtime: let NVDA expose which runtime (32-bit or 64-bit) it is running on #16330

Closed

seanbudd reviewed May 17, 2024

View reviewed changes

source/JABHandler.py Show resolved Hide resolved

source/JABHandler.py Show resolved Hide resolved

user_docs/en/changes.md Outdated Show resolved Hide resolved

seanbudd marked this pull request as draft May 17, 2024 02:28

Update user_docs/en/changes.md

1bc4784

Co-authored-by: Sean Budd <[email protected]>

Modified the Java handler to include the path to the dll for 32-bit s…

3f138b8

…ystems in an NVDA lib folder. The way of checking the system's architecture has also been modified for better readability.

Update JABHandler.py to fix a comentari line too long

b9b4d52

FelipeZanabria marked this pull request as ready for review May 17, 2024 21:32

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 20, 2024

seanbudd reviewed May 21, 2024

View reviewed changes

source/JABHandler.py Outdated Show resolved Hide resolved

Update source/JABHandler.py

9e3c843

seanbudd added the blocked/needs-internal-fix label May 21, 2024

seanbudd marked this pull request as draft May 21, 2024 05:46

seanbudd mentioned this pull request May 22, 2024

Include WindowsAccessBridge.dll to work properly with 32-bit systems nvaccess/javaAccessBridge32-bin#2

Merged

This comment has been minimized.

Sign in to view

This comment was marked as off-topic.

Sign in to view

seanbudd added the blocked label Jun 7, 2024

seanbudd added merge-early Merge Early in a developer cycle and removed blocked labels Jun 11, 2024

seanbudd added the blocked/merge-conflicts Merge conflicts exist on this PR label Jul 29, 2024

seanbudd marked this pull request as draft July 29, 2024 04:26

seanbudd closed this Sep 1, 2024

seanbudd added the Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. label Sep 1, 2024

Fix Java Access Bridge compatibility on 32 bit systems #16557

Fix Java Access Bridge compatibility on 32 bit systems #16557

Conversation

FelipeZanabria commented May 16, 2024 • edited Loading

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

AppVeyorBot commented May 16, 2024

AppVeyorBot commented May 16, 2024

seanbudd May 17, 2024

Choose a reason for hiding this comment

seanbudd May 17, 2024

Choose a reason for hiding this comment

mwhapples commented May 17, 2024

AppVeyorBot commented May 17, 2024

FelipeZanabria commented May 17, 2024 • edited Loading

FelipeZanabria commented May 17, 2024

seanbudd May 21, 2024

Choose a reason for hiding this comment

josephsl commented May 21, 2024 via email

seanbudd commented May 22, 2024

seanbudd commented May 22, 2024

josephsl commented May 27, 2024

This comment has been minimized.

Adriani90 commented May 27, 2024

Adriani90 commented May 27, 2024

FelipeZanabria commented May 27, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

seanbudd commented May 29, 2024

FelipeZanabria commented May 29, 2024 • edited Loading

FelipeZanabria commented May 31, 2024

seanbudd commented Jun 3, 2024

FelipeZanabria commented Jun 3, 2024

FelipeZanabria commented Jun 5, 2024

seanbudd commented Jun 7, 2024

seanbudd commented Jun 7, 2024

seanbudd commented Jun 7, 2024

wmhn1872265132 commented Jun 7, 2024

FelipeZanabria commented Jun 7, 2024

ivnc commented Jun 9, 2024

seanbudd commented Jun 26, 2024

ivnc commented Jul 7, 2024

seanbudd commented Jul 15, 2024

seanbudd commented Sep 1, 2024

FelipeZanabria commented May 16, 2024 •

edited

Loading

FelipeZanabria commented May 17, 2024 •

edited

Loading

FelipeZanabria commented May 29, 2024 •

edited

Loading