Skip to content

Commit

Permalink
App modules: log app architecture as part of dev info (#16972)
Browse files Browse the repository at this point in the history
Closes #16488

Summary of the issue:
Log app architecture as part of app module info.

Description of user facing changes
For developers: developer info for navigator object now includes app architecture for the current app.

Description of development approach
Added apModule.appArchitecture to dev info list in app module class.
  • Loading branch information
josephsl authored Aug 8, 2024
1 parent 46e48b9 commit ef4fb41
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
7 changes: 6 additions & 1 deletion source/appModuleHandler.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: UTF-8 -*-
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2006-2023 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Patrick Zajda, Joseph Lee,
# Copyright (C) 2006-2024 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Patrick Zajda, Joseph Lee,
# Babbage B.V., Mozilla Corporation, Julien Cochuyt, Leonard de Ruijter, Cyrille Bougot
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
Expand Down Expand Up @@ -832,6 +832,11 @@ def _get_devInfo(self) -> List[str]:
except Exception as e:
ret = f"exception: {e}"
info.append(f"appModule.helperLocalBindingHandle: {ret}")
try:
ret = repr(self.appArchitecture)
except Exception as e:
ret = f"exception: {e}"
info.append(f"appModule.appArchitecture: {ret}")
return info


Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Please refer to [the developer guide](https://www.nvaccess.org/files/nvda/docume
* Please consult the [Custom speech symbol dictionaries section in the developer guide](https://www.nvaccess.org/files/nvda/documentation/developerGuide.html#AddonSymbolDictionaries) for more details.
* It is now possible to redirect objects retrieved from on-screen coordinates, by using the `NVDAObject.objectFromPointRedirect` method. (#16788, @Emil-18)
* Running SCons with the parameter `--all-cores` will automatically pick the maximum number of available CPU cores. (#16943, #16868, @LeonarddeR)
* Developer info now includes information on app architecture (such as AMD64) for the navigator object. (#16488, @josephsl)

#### Deprecations

Expand Down

0 comments on commit ef4fb41

Please sign in to comment.