-
-
Notifications
You must be signed in to change notification settings - Fork 654
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unbind application volume adjustment gestures (#17634)
Closes #17272 Summary of the issue: The application volume adjuster feature introduced in #16591 includes default keyboard gestures that: 1. Conflict with the default gestures used by NVDA Remote; and 2. Don't do anything by default, as the feature is disabled. Description of user facing changes These gestures are unbound by default. Users can still bind gestures to these commands from the input gestures dialog. Description of development approach Removed the `gesture` argument to the `script` decorator on `GlobalCommands.script_increaseApplicationsVolume`, `GlobalCommands.script_decreaseApplicationsVolume`, and `GlobalCommands.script_toggleApplicationsMute`. Testing strategy: Ran NVDA from source. Ensured that the commands were unbound by executing the previous keyboard gestures. Re-bound the gestures in the input gestures dialog, and ensured they worked as expected. Known issues with pull request: None.
- Loading branch information
1 parent
a9a081b
commit b8cf4cf
Showing
3 changed files
with
6 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters