Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-25.02 into branch-25.06 #534

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Jan 30, 2025

Forward-merge triggered by push to branch-25.02 that creates a PR to keep branch-25.06 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

This PR simplifies the implementation of `yield_for` and `yield_until` while also eliminating a bug in `yield_for` which can cause it to prematurely notify.

Closes #532

Authors:
  - Will Killian (https://github.com/willkill07)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #533
@rapids-bot rapids-bot bot requested a review from a team as a code owner January 30, 2025 22:54
Copy link
Author

rapids-bot bot commented Jan 30, 2025

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

@willkill07 willkill07 added bug Something isn't working non-breaking Non-breaking change labels Feb 3, 2025
@willkill07 willkill07 merged commit 0a39ed9 into branch-25.06 Feb 3, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant