chore: fix lint errors (#920)

* chore(eslint): update .eslintignore

* chore: fix Vue component ordering

* Adopt correct unused vars for typescript

* chore: suppress specific errors instead of ignore file

Co-authored-by: Brendan Mulholland <[email protected]>

.eslintignore

@@ -2,4 +2,4 @@ templates/
 node_modules
 .nuxt
 dist
-types
+docs/static/sw.js

.eslintrc

@@ -4,6 +4,10 @@
   ],
   "rules": {
     "require-await": 0,
-    "no-useless-constructor": 0
+    "no-useless-constructor": 0,
+    // Correct support for unused var detection in Typescript:
+    // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unused-vars.md
+    "no-unused-vars": "off",
+    "@typescript-eslint/no-unused-vars": ["error"]
   }
 }

demo/pages/login.vue

@@ -110,18 +110,12 @@
   </div>
 </template>
 
-<style scoped>
-.login-button {
-  border: 0;
-}
-</style>
-
 <script>
 import busyOverlay from '~/components/busy-overlay'
 
 export default {
-  middleware: ['auth'],
   components: { busyOverlay },
+  middleware: ['auth'],
   data () {
     return {
       username: '',
@@ -251,3 +245,9 @@ export default {
   }
 }
 </script>
+
+<style scoped>
+.login-button {
+  border: 0;
+}
+</style>

src/index.ts

@@ -58,12 +58,14 @@ declare module 'vue/types/vue' {
 }
 
 declare module 'vue/types/options' {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   interface ComponentOptions<V extends Vue> {
     auth?: true | false | 'guest';
   }
 }
 
 declare module 'vuex/types/index' {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   interface Store<S> {
     $auth: Auth;
   }