Test dt adapter

[gitofanindya]

Summary by Sourcery

Update dependencies to fix security issues and renew MacOS certificate. Ignore zero-byte files during upload.

New Features:

• Set container title when defining the Folder type from Document Type Selection using Direct Transfer.
• Translate "Document type" and "container type" labels on Direct Transfer popup.

Bug Fixes:

• Fixed security issue: urllib3's Proxy-Authorization request header isn't stripped during cross-origin redirects.
• Fixed security issue: pyca/cryptography has a vulnerable OpenSSL included in cryptography wheels.
• Fixed security issue: Black vulnerable to Regular Expression Denial of Service (ReDoS).
• [Mac] Renewed certificate.
• Ignored zero-byte files during upload.

Tests:

• Removed unused MockedPath class.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request upgrades the Python version to 3.12, updates dependencies, and modifies datetime handling to use timezone-aware datetime objects. It also includes documentation updates and a fix for ignoring zero-byte files.

Sequence diagram for timezone-aware datetime handling

sequenceDiagram
    participant LC as LocalClient
    participant DB as SQLite Database
    participant AC as AutoRetryCursor

    LC->>DB: Get file info
    activate LC
    Note over LC: Convert file mtime
    LC->>LC: datetime.fromtimestamp(st_mtime, tz=timezone.utc)
    LC-->>DB: Store timezone-aware datetime
    deactivate LC

    DB->>AC: Execute SQL query
    activate AC
    Note over AC: Adapt datetime for SQLite
    AC->>AC: adapt_datetime_iso()
    AC-->>DB: Store UTC datetime
    deactivate AC

Loading

Class diagram for AutoRetryCursor enhancement

classDiagram
    class AutoRetryCursor {
        +adapt_datetime_iso(val)
        +execute(sql: str, parameters: Iterable[Any])
    }
    class Cursor {
        +execute()
    }

    AutoRetryCursor --|> Cursor

    note for AutoRetryCursor "New timezone handling"

Loading

File-Level Changes

Change	Details	Files
Updated Python version to 3.12 in CI workflows.	Upgraded Python version to 3.12 in functional tests workflow. Upgraded Python version to 3.12 in unit tests workflow. Upgraded Python version to 3.12 in integration tests workflow. Upgraded Python version to 3.12 in lint workflow. Upgraded Python version to 3.12 in spell workflow. Upgraded Python version to 3.12 in style workflow. Upgraded Python version to 3.12 in translations workflow. Upgraded Python version to 3.12 in types workflow.	.github/workflows/integration.yml .github/workflows/lint.yml .github/workflows/spell.yml .github/workflows/style.yml .github/workflows/translations.yml .github/workflows/types.yml .github/workflows/unit.yml .github/workflows/functional.yml
Updated dependencies in requirements.txt.	Upgraded authlib from 1.3.1 to 1.3.2. Upgraded boto3 from 1.35.21 to 1.35.82. Upgraded botocore from 1.35.21 to 1.35.82. Upgraded certifi from 2024.7.4 to 2024.12.14. Upgraded cffi from 1.16.0 to 1.17.1. Upgraded charset-normalizer from 2.1.1 to 3.4.0. Upgraded cryptography from 43.0.1 to 44.0.0. Upgraded distro from 1.5.0 to 1.9.0. Upgraded dukpy from 0.3.1 to 0.5.0. Upgraded idna from 3.7 to 3.10. Upgraded packaging from 24.0 to 24.2. Upgraded psutil from 5.8.0 to 6.1.0. Upgraded pycparser from 2.21 to 2.22. Upgraded pyobjc-core from 10.1 to 10.3.1. Upgraded pyobjc-framework-Cocoa from 10.1 to 10.3.2. Upgraded pyobjc-framework-CoreServices from 10.1 to 10.3.2. Upgraded pyobjc-framework-FSEvents from 10.1 to 10.3.2. Upgraded pyobjc-framework-ScriptingBridge from 10.1 to 10.3.1. Upgraded pyobjc-framework-SystemConfiguration from 10.1 to 10.3.1. Upgraded pypac from 0.15.0 to 0.16.4. Upgraded pyparsing from 2.4.7 to 3.2.0. Upgraded pyqt5-sip from 12.13.0 to 12.16.1. Upgraded PyQt5-Qt5 from 5.15.2 to 5.15.15 for non-darwin platforms. Upgraded python-dateutil from 2.8.2 to 2.9.0.post0. Upgraded pyyaml from 6.0.1 to 6.0.2. Upgraded pywin32 from 306 to 308. Upgraded requests from 2.32.2 to 2.32.3. Upgraded send2trash from 1.7.1 to 1.8.3. Upgraded s3transfer from 0.10.0 to 0.10.4. Upgraded sentry-sdk from 1.28.1 to 2.19.2. Upgraded urllib3 from 1.26.19 to 2.2.3. Upgraded watchdog from 3.0.0 to 6.0.0. Upgraded zipp from 3.20.0 to 3.21.0.	tools/deps/requirements.txt
Modified datetime handling to use timezone-aware datetime objects.	Modified the execute method in AutoRetryCursor to handle timezone-aware datetime objects. Modified the get_info method in LocalClient to handle timezone-aware datetime objects.	nxdrive/dao/base.py nxdrive/client/local/base.py
Updated documentation to reflect the new Python version support.	Updated the documentation to reflect support for Python 3.12.3 instead of 3.9.5. Added a note about ignoring zero-byte files.	docs/changes/5.5.1.md
Implemented ignoring zero-byte files.	Added a check to ignore zero-byte files in the _process_additionnal_local_paths method.	nxdrive/gui/folders_dialog.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @gitofanindya - I've reviewed your changes - here's some feedback:

Overall Comments:

• The sqlite datetime adapter implementation in AutoRetryCursor needs cleanup - remove commented code and avoid direct sqlite3 imports. Consider using the standard sqlite3 date adapters.
• The removal of MockedPath test class reduces test coverage. Please either restore the test coverage or document why these tests are no longer needed.
• Using os.system() for directory removal is unsafe and platform-dependent. Please use pathlib or shutil functions instead.

Here's what I looked at during the review

• 🟡 General issues: 3 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 2 issues found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue: The strftime('%s') format specifier is not guaranteed to work on all platforms, particularly Windows

[sourcery-ai]

suggestion: Use context manager pattern for database connection to ensure proper cleanup

This ensures the connection is closed even if an exception occurs during the dump process.

Suggested change

	con = sqlite3.connect(str(database))
	with dump_file.open(mode="w", encoding="utf-8") as f:
	for line in con.iterdump():
	f.write(f"{line}\n")
	# Force write of file to disk
	f.flush()
	fsync(f.fileno())
	con.close()
	with sqlite3.connect(str(database)) as con, dump_file.open(mode="w", encoding="utf-8") as f:
	for line in con.iterdump():
	f.write(f"{line}\n")
	# Force write of file to disk
	f.flush()
	fsync(f.fileno())

[sourcery-ai]

issue (bug_risk): Incorrect index used for locale code - should be [0] instead of [1]

Index [1] returns the encoding instead of the locale code. This will cause incorrect locale detection.

[sourcery-ai]

issue (testing): Using os.system() for test cleanup is unsafe

Using os.system() for file operations in tests is not recommended as it's platform-dependent and can be unsafe. Consider using pathlib.Path.unlink() or shutil.rmtree() for more reliable cleanup.

[sourcery-ai]

issue (testing): Same unsafe cleanup pattern in test_proxy.py

Similar to the issue in conftest.py, using os.system() for cleanup is not recommended. Use standard Python file operations instead.

[mr-shekhar]

@sourcery-ai review

[sourcery-ai]

Hey @gitofanindya - I've reviewed your changes - here's some feedback:

Overall Comments:

• The use of rmdir instead of unlink() in the tests seems potentially problematic. Consider keeping the original unlink() call or properly handling non-empty directory cases if rmdir is really needed.

Here's what I looked at during the review

• 🟡 General issues: 3 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): The datetime adapter registration approach could cause issues with concurrent database access

Using register_adapter affects the entire SQLite connection. Consider using value adaptation at the parameter level instead. Also, the original code is still present in comments which should be cleaned up.

[sourcery-ai]

suggestion: Consider extracting the zero-byte file check into a helper method to avoid code duplication

The zero-byte file check logic is repeated. Consider creating a helper method like _should_skip_file(path) to handle this check in both cases.

Suggested implementation:

    def get_size(self, file_path: Path) -> bool:
        return file_path.stat().st_size

    def _should_skip_file(self, file_path: Path) -> bool:
        """Check if file should be skipped (zero-byte files) [NXDRIVE-2925]."""
        return self.get_size(file_path) == 0

                    if self._should_skip_file(file_path):
                        continue

                    file_size = self.get_size(path)
                    if self._should_skip_file(path):
                        continue
                    self.paths[path] = file_size

[sourcery-ai]

suggestion: Use a context manager for database connection to ensure proper resource cleanup

While the connection is being closed explicitly, using a context manager (with statement) would be safer and ensure the connection is closed even if an exception occurs.