Merge pull request #179 from nulib/5304-bad-uri

Don't match getty on bad uri with colon at start of string
nulib · Dec 12, 2024 · d94e200 · d94e200
2 parents 33a4a20 + 82686fa
commit d94e200
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/authoritex/getty/base.ex b/lib/authoritex/getty/base.ex
@@ -18,7 +18,9 @@ defmodule Authoritex.Getty.Base do
 
       @impl Authoritex
       def can_resolve?(unquote(http_uri) <> _id), do: true
-      def can_resolve?(unquote(prefix) <> _id), do: true
+      def can_resolve?(unquote(prefix) <> _ = id) do
+        unquote(prefix) != ":"
+      end
       def can_resolve?(_), do: false
 
       @impl Authoritex

diff --git a/test/authoritex_test.exs b/test/authoritex_test.exs
@@ -44,6 +44,11 @@ defmodule AuthoritexTest do
       assert Authoritex.fetch("info:fake/no-authority/12345") ==
                {:error, :unknown_authority}
     end
+
+    test "bad uri" do
+      assert Authoritex.fetch(":http://id.loc.gov/authorities/names/no2009131449") ==
+               {:error, :unknown_authority}
+    end
   end
 
   describe "search/2" do