Experimental elision feature fix: Preserve metadata on sets to make it work with feature #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, with `(match? [#{2}] [#{1 2}])` it currently gives
`[#{(unexpected 1)} ...]`
This feels misleading to me because there aren't more elements in the
vector that are being elided.
It should be more like `[#{(unexpected 1) ...}]` or at worst
something like `[#{(unexpected 1) ...} ...]`
philomates
commented
Jan 17, 2025
| @@ -246,7 +246,8 @@ | |||
|
|
|||
| (defn- type-preserving-mismatch [base-list values] | |||
| (let [lst (into base-list values)] | |||
| (if (vector? base-list) | |||
| (if (or (vector? base-list) | |||
| (set? base-list)) | |||
| lst | |||
| (reverse lst)))) | |||
There was a problem hiding this comment.
without this change we were turning a set into a list due to reverse
philomates
changed the title
philomates
commented
Jan 17, 2025
| (:unmatched result))) | ||
| (:elements result)) | ||
| ::result/value | ||
| #(with-mismatch-meta % :mismatch-sequence))))) |
There was a problem hiding this comment.
add :mismatch-sequence metadata, which is used by the elision feature, to the result of any-order/set mismatch results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #222