Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix position.side #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix position.side #4

wants to merge 1 commit into from

Conversation

fredguth
Copy link

@fredguth fredguth commented Oct 4, 2023

Hacky way to fix position.side. It is assuming a specific biding. Probably won't work in right-to-left languages.

Hacky way to fix position.side. It is assuming a specific `biding`. Probably won't work in right-to-left languages.
@ntjess
Copy link
Owner

ntjess commented Oct 4, 2023

Thanks for the PR! However, I would avoid merging for a few reasons:

  1. As you noted, binding will change what this default should be, so I wouldn't want unexpected behavior as a result of swapping l/r on an odd page. Moreover, the margins are only swapped if binding is specified in the first place, otherwise they stay on their respective sides. Therefore, it makes the most sense to wait until get rules are implemented to detect these cases.
  2. It is possible to use margin-note in a smaller container -- it's how the minipages in the manual are generated:
    image
    In this case, it wouldn't be ideal to artificially swap left- and right-margin values based on the current page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants