docs(core): add comment to print affected change;

nrwl · Oct 3, 2022 · b0b8234 · b0b8234
1 parent 0fbff69
commit b0b8234
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/e2e/js/src/js.test.ts b/e2e/js/src/js.test.ts
@@ -235,16 +235,12 @@ describe('js e2e', () => {
 
     runCLI(`build ${lib}`);
 
-    const rootPackageJson = readJson(`package.json`);
+    const swcHelpersFromRoot =
+      readJson(`package.json`).dependencies['@swc/helpers'];
+    const swcHelpersFromDist = readJson(`dist/libs/${lib}/package.json`)
+      .peerDependencies['@swc/helpers'];
 
-    expect(
-      satisfies(
-        readJson(`dist/libs/${lib}/package.json`).peerDependencies[
-          '@swc/helpers'
-        ],
-        rootPackageJson.dependencies['@swc/helpers']
-      )
-    ).toBeTruthy();
+    expect(satisfies(swcHelpersFromDist, swcHelpersFromRoot)).toBeTruthy();
 
     updateJson(`libs/${lib}/.lib.swcrc`, (json) => {
       json.jsc.externalHelpers = false;

diff --git a/packages/js/src/utils/versions.ts b/packages/js/src/utils/versions.ts
@@ -4,5 +4,5 @@ export const nxVersion = require('../../package.json').version;
 
 export const esbuildVersion = '^0.15.7';
 export const swcCliVersion = '~0.1.55';
-export const swcHelpersVersion = '~0.3.3';
+export const swcHelpersVersion = '~0.4.11';
 export const typesNodeVersion = '18.7.1';
diff --git a/packages/nx/src/command-line/print-affected.ts b/packages/nx/src/command-line/print-affected.ts
@@ -87,6 +87,8 @@ async function createTasks(
 function serializeProjectGraph(projectGraph: ProjectGraph) {
   const nodes = Object.values(projectGraph.nodes).map((n) => n.name);
   const dependencies = {};
+  // we don't need external dependencies' dependencies for print-affected
+  // having them included makes the output unreadable
   Object.keys(projectGraph.dependencies).forEach((key) => {
     if (!key.startsWith('npm:')) {
       dependencies[key] = projectGraph.dependencies[key];

diff --git a/packages/webpack/src/utils/versions.ts b/packages/webpack/src/utils/versions.ts
@@ -1,5 +1,5 @@
 export const nxVersion = require('../../package.json').version;
 
 export const swcLoaderVersion = '0.1.15';
-export const swcHelpersVersion = '~0.3.3';
+export const swcHelpersVersion = '~0.4.11';
 export const tsLibVersion = '^2.3.0';