Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error type assertion with errors.As #25

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix: error type assertion with errors.As #25

merged 2 commits into from
Dec 6, 2023

Conversation

gjarmstrong
Copy link
Contributor

Linear Ticket Link

N/A

Description

Currently the errors package uses type assertion to check for a customErr which doesn't work with wrapped errors. Replaced the type assertions with errors.As usage.

How did you test the changes?

  • Create unit test

Dependencies

N/A

@gjarmstrong gjarmstrong added the Type: Bug Something isn't working label Dec 5, 2023
m-bodmer
m-bodmer approved these changes Dec 5, 2023
View reviewed changes
Copy link

@m-bodmer m-bodmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. Welcomed change!

@josemarluedke josemarluedke merged commit 31c154f into main Dec 6, 2023
@josemarluedke josemarluedke deleted the chore/remove-type-assertion branch December 6, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bodmer m-bodmer m-bodmer approved these changes

@josemarluedke josemarluedke Awaiting requested review from josemarluedke

@graywolf336 graywolf336 Awaiting requested review from graywolf336

Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjarmstrong @m-bodmer @josemarluedke