Validate encrypted content before writing it to RAM #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the encrypted application manifest so first decrypts the encrypted content without storing it to MRAM, in order to verify if the the AAD and Tag are correct. If it wasn't done, then the device would need to enter recovery in case of a decryption failure. Ref: NCSDK-30932 Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
requested review from
tomchy,
SylwesterKonczyk,
robertstypa and
adsz-nordic
ahasztag
changed the title
|
pytest coverage results
Note: This message is automatically posted and updated by the CI (latest/test-sdk-dfu/master/267) |
adsz-nordic
approved these changes
Dec 20, 2024
tomchy
approved these changes
Dec 20, 2024
| @@ -136,19 +121,16 @@ SUIT_Envelope_Tagged: | |||
| suit-digest-algorithm-id: cose-alg-sha-256 | |||
| suit-digest-bytes: | |||
| file: {{ application['encryption_artifacts_dir'] }}/encrypted_content.bin | |||
| suit-parameter-encryption-info: | |||
There was a problem hiding this comment.
-
What is a meaning of line 120 (setting parameter-image-digest)?
-
Why in case of suit-candidate-verification (line 119) just that URI is considered:
suit-parameter-uri: '#{{ application['name'] }}'... while, in case of suit-install (line 81), also that one is considered:
suit-parameter-uri: '{{ application['config']['CONFIG_SUIT_IMAGE_DFU_CACHE_URI'] }}'
robertstypa
approved these changes
Jan 10, 2025
|
I think you should rebase & redirect the PR to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the encrypted application manifest so first decrypts the encrypted content without storing it to MRAM, in order to verify if the the AAD and Tag are correct.
If it wasn't done, then the device would need to enter recovery in case of a decryption failure.