[nrf fromtree] modules: hal_nordic: use CLOCK_CONTROL_NRF2 for HFCLK … #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request/release Makes 802.15.4 use the API under CONFIG_CLOCK_CONTROL_NRF2 in nrf_clock_control.h to request/release HFCLK. Previous HFCLK requesting/releasing on nRF54H20 was more of a workaround and could produce issues when comes to sharing the resources. Signed-off-by: Piotr Koziar <[email protected]> (cherry picked from commit b6ca9dbc713bffd80ad6a5d5b4cb4564fd192042)
|
FYI @ankuns |
ankuns
approved these changes
Jan 21, 2025
|
Some fix is missing, see CI: zephyr/modules/hal_nordic/nrf_802154/sl_opensource/platform/nrf_802154_clock_zephyr.c:36:13: warning: 'hfclk_on_callback' defined but not used [-Wunused-function] zephyr/modules/hal_nordic/nrf_802154/sl_opensource/platform/nrf_802154_clock_zephyr.c:34:28: warning: 'hfclk_cli' defined but not used The upstream commit is not enough. Please make it build in our CI here, then put necessary fix in upstream, then replace the fix commit with the cherrypick. |
…4 RD Selects CLOCK_CONTROL config whenever nRF 802.15.4 Radio Driver is enabled. The driver requires HFCLK api available under the config switch. Upstream PR #: 84343 Signed-off-by: Piotr Koziar <[email protected]>
|
Decided to go with zephyrproject-rtos/zephyr#84343 that will enable the CLOCK_CONTROL required to use the zephyr's changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…request/release
Makes 802.15.4 use the API under CONFIG_CLOCK_CONTROL_NRF2 in nrf_clock_control.h to request/release HFCLK.
Previous HFCLK requesting/releasing on nRF54H20 was more of a workaround and could produce issues when
comes to sharing the resources.
Signed-off-by: Piotr Koziar [email protected]
(cherry picked from commit b6ca9db)