Revert "[nrf noup] hostap: Avoid double-definition of base64 APIs" #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
reviewed
Dec 16, 2024
krish2718
force-pushed
the
fix_base64_build_errors
branch
from
1090cb5 to
64aa67c
Compare
nordicjm
approved these changes
Dec 16, 2024
krish2718
requested review from
jukkar and
sachinthegreen
and removed request for
D-Triveni
D-Triveni
approved these changes
Dec 17, 2024
krish2718
force-pushed
the
fix_base64_build_errors
branch
from
64aa67c to
1247f1d
Compare
nrf-squash! [nrf noup] hostap: Avoid double-definition of base64 AP This reverts commit 4bbe53c. The file definitions have been modified to include "hostap" namespace, so, this file is must for build. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
fix_base64_build_errors
branch
from
1247f1d to
10b9727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4bbe53c.
The file definitions have been modified to include "hostap" namespace, so, this file is must for build.