[nrf noup] soc: nordic: add delay after wake up #1995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
adamkondraciuk
requested review from
jonathannilsen,
meijemac and
nordic-pikr
and removed request for
kl-cruz,
anangl,
nika-nordic,
masz-nordic,
magp-nordic and
jaz1-nordic
adamkondraciuk
force-pushed
the
NRFX-6317-add-delay-at-wakeup
branch
from
fb87b9b to
98d1d02
Compare
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
nordic-piks
approved these changes
Sep 4, 2024
adamkondraciuk
force-pushed
the
NRFX-6317-add-delay-at-wakeup
branch
from
98d1d02 to
13109f6
Compare
|
Can you add a comment with why this is needed? |
adamkondraciuk
force-pushed
the
NRFX-6317-add-delay-at-wakeup
branch
from
13109f6 to
c5d62db
Compare
anangl
requested changes
Sep 5, 2024
soc/nordic/nrf54h/power.c
Outdated
| @@ -33,7 +33,6 @@ static void suspend_common(void) | |||
|
|
|||
| /* Disable retention */ | |||
| nrf_lrcconf_retain_set(NRF_LRCCONF010, NRF_LRCCONF_POWER_DOMAIN_0, false); | |||
| nrf_lrcconf_poweron_force_set(NRF_LRCCONF010, NRF_LRCCONF_POWER_DOMAIN_0, false); | |||
There was a problem hiding this comment.
This change looks unrelated, and neither change has a comment that marks it as workaround or temporary when a better solution is in place
An additional delay after wake-up is needed. Signed-off-by: Adam Kondraciuk <[email protected]>
adamkondraciuk
force-pushed
the
NRFX-6317-add-delay-at-wakeup
branch
from
c5d62db to
35e01a9
Compare
|
To my understanding we shouldn't do the delay method but just wait for a proper fix in sysctrl that doesn't turn on closed loop for fll16m. or is this supposed to fix something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An additional delay after wake-up is needed.