Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: General fixup #20064

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

suit: General fixup #20064

wants to merge 3 commits into from

Conversation

nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Jan 24, 2025

Fixes various styling issues with Kconfig files and changes Kconfig
option names that duplicate information which is already known
which would lead to more unselectable Kconfig options in future for
additional SoCs, lessening the complexity and maintenance burden.
Also fixes an issue that was completely hidden whereby an existing
Zephyr Kconfig was re-defined, completely obscuring the fact that
the original Zephyr Kconfig was removed in 4.0 and had been doing
nothing since the upmerge to that version of Zephyr

Use CMake to select MCI implementation, based on the SoC.
Use Kconfig to enable SDFW (common for all nordic platforms) or custom
implementation.
Refactor one of the tests to allow for such change.

Ref: NCSDK-NONE

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@nordicjm nordicjm requested review from a team as code owners January 24, 2025 10:03
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 24, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 24, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: af92dee689b422badf1800bd8fe7f1d9779cef72

more details

sdk-nrf:

PR head: af92dee689b422badf1800bd8fe7f1d9779cef72
merge base: fbec23918dc1b8da6eb796d4ec524634180857cd
target head (main): a14efda70dbef70e0a2a6dc27f66a5f63f7fc2a6
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (33)
subsys
│  ├── suit
│  │  ├── cache
│  │  │  │ Kconfig
│  │  ├── mci
│  │  │  ├── CMakeLists.txt
│  │  │  │ Kconfig
│  │  ├── memptr_storage
│  │  │  │ Kconfig
│  │  ├── platform
│  │  │  │ Kconfig
│  │  ├── storage
│  │  │  ├── CMakeLists.txt
│  │  │  │ Kconfig
│  │  ├── stream
│  │  │  │ Kconfig
│  │  ├── validator
│  │  │  ├── CMakeLists.txt
│  │  │  │ Kconfig
tests
│  ├── subsys
│  │  ├── suit
│  │  │  ├── cache_pool_digest
│  │  │  │  │ CMakeLists.txt
│  │  │  ├── check_content
│  │  │  │  │ Kconfig
│  │  │  ├── check_image_match
│  │  │  │  │ Kconfig
│  │  │  ├── cmake
│  │  │  │  │ test_template.cmake
│  │  │  ├── common
│  │  │  │  │ CMakeLists.txt
│  │  │  ├── component_compatibility_check
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ prj.conf
│  │  │  ├── copy
│  │  │  │  │ Kconfig
│  │  │  ├── digest_sink
│  │  │  │  │ CMakeLists.txt
│  │  │  ├── envelope_decoder
│  │  │  │  │ Kconfig
│  │  │  ├── fetch_integrated_payload_flash
│  │  │  │  │ Kconfig
│  │  │  ├── flash_sink
│  │  │  │  │ CMakeLists.txt
│  │  │  ├── manifest_variables
│  │  │  │  │ Kconfig
│  │  │  ├── orchestrator
│  │  │  │  ├── orchestrator_app
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── orchestrator_sdfw
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── orchestrator_sdfw_nrf54h20
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │ prj.conf
│  │  │  ├── storage
│  │  │  │  │ Kconfig
│  │  │  ├── storage_nrf54h20
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ prj.conf
│  │  │  ├── tests
│  │  │  │  ├── Kconfig
│  │  │  │  ├── sdfw
│  │  │  │  │  │ Kconfig
│  │  │  ├── write
│  │  │  │  │ Kconfig

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 117
  • ✅ Integration tests
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Fixes various styling issues with Kconfig files and changes Kconfig
option names that duplicate information which is already known
which would lead to more unselectable Kconfig options in future for
additional SoCs, lessening the complexity and maintenance burden.
Also fixes an issue that was completely hidden whereby an existing
Zephyr Kconfig was re-defined, completely obscuring the fact that
the original Zephyr Kconfig was removed in 4.0 and had been doing
nothing since the upmerge to that version of Zephyr

Signed-off-by: Jamie McCrae <[email protected]>
Updates to use new Kconfig symbol names, and enables usage of the
test Kconfig only in tests to prevent accidental selection by
users where it should not be able to be selected

Signed-off-by: Jamie McCrae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants