Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drivers: sdp_asm: Fix build error #20061

Merged

Conversation

nordic-segl
Copy link
Contributor

@nordic-segl nordic-segl commented Jan 24, 2025

Twister is unable to build tests/drivers/sdp_asm.
However, issue is not observed when test is compiled with 'west build'.

test_low_level: PR-1796

@nordic-segl nordic-segl requested review from a team as code owners January 24, 2025 08:43
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 24, 2025
@nordic-piks
Copy link
Contributor

Please revert f225bde to actually build this code.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 24, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 6052fe675c69faa0228d9e50765182a8828edc79

more details

sdk-nrf:

PR head: 6052fe675c69faa0228d9e50765182a8828edc79
merge base: 983977e0050643b84d8f7647a137472ab910adf4
target head (main): cfd224a72298ed39883f08b96df7257fe7e04cdd
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
scripts
│  │ quarantine.yaml
tests
│  ├── drivers
│  │  ├── sdp_asm
│  │  │  ├── pytest
│  │  │  │  │ test_sdp_asm.py
│  │  │  ├── src
│  │  │  │  ├── add_1.c
│  │  │  │  ├── add_10.c
│  │  │  │  ├── add_100.c
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 38
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nordic-segl nordic-segl force-pushed the NCSDK-31409_Fix-test-drivers-sdp_asm branch from 54d5072 to 6690e66 Compare January 24, 2025 09:29
@nordic-segl nordic-segl requested a review from a team as a code owner January 24, 2025 09:29
This reverts commit f225bde.

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NCSDK-31409_Fix-test-drivers-sdp_asm branch from 6690e66 to efa8224 Compare January 24, 2025 10:01
@@ -62,8 +62,7 @@ def test_sdp_asm(dut: DeviceAdapter):
execute_shell_cmd(cmd, f"{BUILD_DIR}")

logger.info("# Reflash")
cmd = ['west', 'flash', '--erase']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'west flash --erase' doesn't know by itself which target shall be flashed when multiple DKs are connected to the host PC.

@nordic-segl nordic-segl removed the DNM label Jan 24, 2025
Twister is unable to build tests/drivers/sdp_asm.
However, issue is not observed when test is compiled
with 'west build'.

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NCSDK-31409_Fix-test-drivers-sdp_asm branch from efa8224 to 6052fe6 Compare January 24, 2025 10:33
@nordic-piks nordic-piks merged commit 2e8ae9b into nrfconnect:main Jan 24, 2025
12 checks passed
@nordic-segl nordic-segl deleted the NCSDK-31409_Fix-test-drivers-sdp_asm branch January 24, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants