Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Add support for Ed25519PH #20050

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ahasztag
Copy link
Contributor

Enabled building SUIT envelopes with Ed25519PH and their verification by the SUIT bootloader.

Enabled building SUIT envelopes with Ed25519PH and
their verification by the SUIT bootloader.

Signed-off-by: Artur Hadasz <[email protected]>
@ahasztag ahasztag requested review from a team as code owners January 23, 2025 10:53
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 23, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 23, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
suit-generator nrfconnect/suit-generator@b37972c (main) nrfconnect/suit-generator#167 nrfconnect/suit-generator#167/files
suit-processor nrfconnect/suit-processor@a499bca (main) nrfconnect/suit-processor#101 nrfconnect/suit-processor#101/files

DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 23, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 31ce9affa6e184e6ff176c064aace37dc2122fac
suit-generator: PR head: 58b9c3ec97323fb2721da876997f56bdf8046424
suit-processor: PR head: 861d1234ce44b8d5a7ec8091ee52a1f124d25363

more details

sdk-nrf:

PR head: 31ce9affa6e184e6ff176c064aace37dc2122fac
merge base: e24b7684210b99007a518e261b4bedae025ebf4a
target head (main): 3daaaad74e03a8f5d530a4e1079a8c40063fca7b
Diff

suit-generator:

PR head: 58b9c3ec97323fb2721da876997f56bdf8046424
merge base: b37972cd90c122bb8f384f2509b72fad62c3aa4b
target head (main): b37972cd90c122bb8f384f2509b72fad62c3aa4b
Diff

suit-processor:

PR head: 861d1234ce44b8d5a7ec8091ee52a1f124d25363
merge base: a499bcadceff8877da63a0a140c6a91ff2f87b25
target head (main): a499bcadceff8877da63a0a140c6a91ff2f87b25
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (19)
modules
│  ├── lib
│  │  ├── suit-generator
│  │  │  ├── .gitignore
│  │  │  ├── ncs
│  │  │  │  ├── Kconfig
│  │  │  │  ├── basic_kms.py
│  │  │  │  │ sign_script.py
│  │  │  ├── suit_generator
│  │  │  │  ├── suit
│  │  │  │  │  ├── security.py
│  │  │  │  │  ├── types
│  │  │  │  │  │  │ keys.py
│  │  │  │  │ suit_sign_script_base.py
│  │  ├── suit-processor
│  │  │  ├── cddl
│  │  │  │  │ cose_sign.cddl
│  │  │  ├── include
│  │  │  │  │ suit_types.h
│  │  │  ├── tests
│  │  │  │  ├── unit
│  │  │  │  │  ├── decoder
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ test_authenticate_manifest.c
subsys
│  ├── suit
│  │  ├── mci
│  │  │  ├── include
│  │  │  │  │ suit_mci.h
│  │  │  ├── src
│  │  │  │  │ suit_mci_nrf54h20.c
│  │  ├── platform
│  │  │  ├── sdfw
│  │  │  │  ├── src
│  │  │  │  │  │ suit_plat_authenticate.c
sysbuild
│  │ Kconfig.suit
tests
│  ├── subsys
│  │  ├── suit
│  │  │  ├── common
│  │  │  │  ├── mci_test
│  │  │  │  │  │ mci_test.c
│  │  │  ├── mci
│  │  │  │  ├── src
│  │  │  │  │  ├── api_positive_scenarios.c
│  │  │  │  │  │ sanity.c
│  │  │  ├── unit
│  │  │  │  ├── mocks
│  │  │  │  │  ├── include
│  │  │  │  │  │  │ mock_suit_mci.h
west.yml

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • 🟡 Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc - Error: Error starting job: null
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ❌ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-sidewalk
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps
    • ✅ test-secdom-samples-public
    • ⚠️ test-sdk-dfu

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 23, 2025

Memory footprint analysis revealed the following potential issues

sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 912194[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 821134[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-20050/3)

@ahasztag ahasztag marked this pull request as draft January 23, 2025 13:41
@ahasztag
Copy link
Contributor Author

Converting to draft, as it turned out the MCI code needs to be extended

@ahasztag ahasztag marked this pull request as ready for review January 23, 2025 15:37
Nordic elements can only use EdDSA, not Hashed EdDSA

Signed-off-by: Artur Hadasz <[email protected]>
@ahasztag ahasztag force-pushed the NCSDK-31353_ed25519ph branch from ae4a67c to 31ce9af Compare January 23, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-suit-generator manifest-suit-processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants