Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Refer test commands section of BLE Core Spec in DTM sample #19775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions samples/bluetooth/direct_test_mode/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Bluetooth: Direct Test Mode
:depth: 2

This sample enables the Direct Test Mode functions described in `Bluetooth® Core Specification <Bluetooth Core Specification_>`_ (Vol. 6, Part F).
The actual encoding of the test commands and events are described in Vol. 6, Part F, section 3.3 of this specification document.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Is it encoding of test commands and encoding of events? If yes, then ... is described.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my understanding its encoded test commands and events. @grochu : Please confirm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked directly to the spec. The section 3.3 name is "Commands and events" but it describes the encoding of commands only. The actual bit encoding of events is described in the next section: 3.4. So I'd mention both sections here. Since we want to be very clear to the customers, I'd be specific that 3.3 is for commands and 3.4 for events and there should be no doubt.

The `Vendor-specific packet payload`_ section describes some vendor-specific commands that comply with the core specification.

Requirements
************
Expand Down