-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Reduce size of some svgs #19769
Conversation
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 6a82f6e3dd8e9e72786d3e7748f4a67ef6222c4d more detailssdk-nrf:
Github labels
List of changed files detected by CI (17)
Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
bd01156
to
e30e21f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we ok switching from SVG to webp (binary, non-scalable) format? What is the size reduction?
These images were originally hardware drawings generated using AutoCAD and they failed CI (whenever edits are made to the RSTs containing the images) because of image size > 250kb. Although @mirjaku tried reducing their sizes, it could not be made below 250 kb. Now with this webp format (as per your suggestion in the JIRA NCSDK-22370), these images can be made lesser in size (<250 kb) with the same quality. |
NCSDK-22369 NCSDK-22370 To preserve quality and to have reduced sizes, some of the SVGs are now converted into webp format. Signed-off-by: Uma Praseeda <[email protected]>
e30e21f
to
6a82f6e
Compare
NCSDK-22369
NCSDK-22370
To preserve quality and to have reduced sizes (to meet CI compliance image size requirements), some of the SVGs are now converted into webp format.