-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_security: Fix dependency for threading_alt.h #19754
Conversation
Vge0rge
commented
Jan 6, 2025
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: e14a45d378fb0118153cfa3ded273583731259fc more detailssdk-nrf:
nrfxlib:
Github labels
List of changed files detected by CI (4)
Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems you are missing a word or so in this sentence:
The definitions of the mutexes included in the files
nrf_cc3xx_platform_mutex_(zephyr/freertos).c
Edit: Apparently, this is another issue:
|
ping @nrfconnect/ncs-co-build-system @nrfconnect/ncs-code-owners |
1006d6c
to
3d4480e
Compare
Updates nrfxlib which moves the threading_alt.h to the CC3XX platform folder. Ref: NCSDK-31155 Signed-off-by: Georgios Vasilakis <[email protected]>
This fixes a dependency when including the threading_alt.h from nrf_security. The CC3XX platform library provides the implementation of the mbedtls_mutex functions and it expects the mbedTLS mutexes to be of type nrf_cc3xx_platform_mutex_t. The definitions of the mutexes included in the files nrf_cc3xx_platform_mutex_(zephyr/freertos).c The threading_alt.c in nrf_security defines the mbedTLS mutexes as Zephyr mutexes (k_mutex). This doesn't work when the CC3XX platform library is used, so here this dependency is added. Ref: NCSDK-31155 Signed-off-by: Georgios Vasilakis <[email protected]>
3d4480e
to
e14a45d
Compare