Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpsl: enable use of nrfx_power_constlat_mode #17654

Merged

Conversation

martintv
Copy link
Contributor

@martintv martintv commented Oct 6, 2024

Enable application to have several modules requesting constlat. Right now, on 54l, mpsl just writes to NRF_POWER directly, disregarding what other users in system might want constlat to be.

This PR prepares for a soon commig nrfxlib PR where mpsl will rather use mpsl_constlat_request_callback to turn on constlat. If NRFX_POWER modules is enabled in config,
it will use nrfx_power_constlat_mode_request,
if not it will use NRF_POWER diretly.

@martintv martintv requested a review from a team as a code owner October 6, 2024 16:36
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 6, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 6, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: fd80fa221ec6fe1478ff221baf4d3d7d8998a0c1

more details

sdk-nrf:

PR head: fd80fa221ec6fe1478ff221baf4d3d7d8998a0c1
merge base: f91a24744ca92733574de7926c5d353c5724a76f
target head (main): f91a24744ca92733574de7926c5d353c5724a76f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
subsys
│  ├── mpsl
│  │  ├── init
│  │  │  │ mpsl_init.c

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 801
  • ✅ Integration tests
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@martintv martintv force-pushed the make_mpsl_use_nrfx_to_turn_on_constlat branch 3 times, most recently from c26b730 to cac7580 Compare October 7, 2024 08:52
@hermabe hermabe removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 7, 2024
@martintv martintv added this to the 2.8.0 milestone Oct 7, 2024
@martintv martintv force-pushed the make_mpsl_use_nrfx_to_turn_on_constlat branch from cac7580 to 60a5e45 Compare October 8, 2024 08:26
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 8, 2024
Enable application to have several modules requesting constlat.
Right now, on 54l, mpsl just writes to NRF_POWER directly, disregarding
what other users in system might want constlat to be.

This PR prepares for a soon commig nrfxlib PR where mpsl will rather
use mpsl_constlat_request_callback to turn on constlat.
If NRFX_POWER modules is enabled in config,
it will use nrfx_power_constlat_mode_request,
if not it will use NRF_POWER diretly.

Signed-off-by: Martin Tverdal <[email protected]>
@martintv martintv force-pushed the make_mpsl_use_nrfx_to_turn_on_constlat branch from 60a5e45 to fd80fa2 Compare October 8, 2024 10:50
@martintv martintv removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 8, 2024
@rlubos rlubos merged commit 85cfade into nrfconnect:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants