doc: migration guide: add missing toggles

So that everything is as it should be. Signed-off-by: Tomi Fontanilles <[email protected]>
nrfconnect · Sep 26, 2024 · b1871c4 · b1871c4
1 parent 9102e5e
commit b1871c4
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 13 deletions.
diff --git a/doc/nrf/releases_and_maturity/migration/migration_guide_2.8.rst b/doc/nrf/releases_and_maturity/migration/migration_guide_2.8.rst
@@ -85,13 +85,15 @@ SUIT DFU for nRF54H20
 Nordic Secure Immutable Bootloader (NSIB, B0, or B0n)
 -----------------------------------------------------
 
-Custom printing has been dropped in favor of using the logging subsystem, with output printed out to the default logging device.
-The ``CONFIG_SECURE_BOOT_DEBUG`` Kconfig option has been removed.
-To disable logging in B0 or B0n, set the :kconfig:option:`CONFIG_LOG` option to ``n``.
-To send logs over RTT instead of UART, apply the following settings:
+.. toggle::
+
+   Custom printing has been dropped in favor of using the logging subsystem, with output printed out to the default logging device.
+   The ``CONFIG_SECURE_BOOT_DEBUG`` Kconfig option has been removed.
+   To disable logging in B0 or B0n, set the :kconfig:option:`CONFIG_LOG` option to ``n``.
+   To send logs over RTT instead of UART, apply the following settings:
 
-    * Enable the :kconfig:option:`CONFIG_USE_SEGGER_RTT` and :kconfig:option:`CONFIG_RTT_CONSOLE` Kconfig options.
-    * Disable the :kconfig:option:`CONFIG_UART_CONSOLE` and :kconfig:option:`CONFIG_SERIAL` Kconfig options.
+       * Enable the :kconfig:option:`CONFIG_USE_SEGGER_RTT` and :kconfig:option:`CONFIG_RTT_CONSOLE` Kconfig options.
+       * Disable the :kconfig:option:`CONFIG_UART_CONSOLE` and :kconfig:option:`CONFIG_SERIAL` Kconfig options.
 
 Libraries
 =========
@@ -120,8 +122,8 @@ AT command parser
 
   * The :c:func:`at_parser_cmd_type_get` has been renamed to :c:func:`at_parser_at_cmd_type_get`.
 
-Security libraries
-------------------
+nRF Security
+------------
 
 .. toggle::
 
@@ -366,4 +368,6 @@ This section provides detailed lists of changes by :ref:`protocol <protocols>`.
 Bluetooth® LE
 -------------
 
-*  To use the Zephyr Bluetooth LE Controller, use the :ref:`bt-ll-sw-split <zephyr:snippet-bt-ll-sw-split>` snippet (see :ref:`app_build_snippets`).
+.. toggle::
+
+   *  To use the Zephyr Bluetooth LE Controller, use the :ref:`bt-ll-sw-split <zephyr:snippet-bt-ll-sw-split>` snippet (see :ref:`app_build_snippets`).
diff --git a/subsys/nrf_security/src/drivers/cracen/Kconfig b/subsys/nrf_security/src/drivers/cracen/Kconfig
@@ -46,8 +46,8 @@ config CRACEN_IKG_SEED_KMU_SLOT
 	range 0 183
 	default 183
 	help
-	  The Cracen IKG seed spans over 3 KMU slots:
-	  the one defined here plus the two following it.
+	  The CRACEN IKG seed spans over 3 KMU slots:
+	  the one defined here and the two subsequent ones.
 	  This defines the KMU slot (along with the two following it) to which
 	  the IKG seed is provisioned and that is pushed when loading the IKG seed.
 

diff --git a/subsys/nrf_security/src/drivers/cracen/cracenpsa/include/cracen_psa_kmu.h b/subsys/nrf_security/src/drivers/cracen/cracenpsa/include/cracen_psa_kmu.h
@@ -41,7 +41,7 @@ enum kmu_metadata_key_usage_scheme {
 	 */
 	KMU_METADATA_SCHEME_PROTECTED,
 	/**
-	 * These keys use 3 key slots. Pushed to the seed register.
+	 * CRACEN's IKG seed uses 3 key slots. Pushed to the seed register.
 	 */
 	KMU_METADATA_SCHEME_SEED,
 	/**

diff --git a/subsys/nrf_security/src/drivers/cracen/cracenpsa/src/lib_kmu.c b/subsys/nrf_security/src/drivers/cracen/cracenpsa/src/lib_kmu.c
@@ -71,7 +71,9 @@ int lib_kmu_provision_slot(int slot_id, struct kmu_src_t *kmu_src)
 		return -LIB_KMU_NULL_PNT;
 	}
 
-	/* DEST must be 64/128-bit aligned */
+	/* The DEST address must be 64-bit aligned on nrf54l15pdk.
+	 * On nrf54l15dk, the alignment requirement changed to 128 bits.
+	 */
 	__ASSERT(IS_PTR_ALIGNED_BYTES(kmu_src->dest,
 				      (IS_ENABLED(CONFIG_SOC_NRF54L15_ENGA_CPUAPP) ? 8 : 16)),
 		 "DEST misaligned");