feat: add support for ConEmu indeterminate progress indicator #8047
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for: https://conemu.github.io/en/AnsiEscapeCodes.html#OSC_Operating_system_commands Note: this code works only on ConEmu terminals, and conflicts with push a notification code on iTerm2. Ref: https://iterm2.com/documentation-escape-codes.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for:
https://conemu.github.io/en/AnsiEscapeCodes.html#OSC_Operating_system_commands
The Windows Terminal supports above mentioned Ansi Code extensions. Thoese extensions originate from ConEmu and were also added to the
dotnetcliOn windows, this displays a spinner in the current tab. It also marks the respective taskbar item as indeterminate progressing. See it in action:
(mp4)
The user is able to minimize the terminal and is still informed about the state of the npm operation.
Note: this code works only on ConEmu terminals, and conflicts with push a notification code on iTerm2.
https://iterm2.com/documentation-escape-codes.html
I could not check what exactly happens in iTerm2, maybe someone else can check this. If that ends up being a problem, we should exclude macOS from this feature.
If this doesn't align with the goals of npm-cli, just close this PR without any comment.