fix(api-service): translation groups causing long response time in v2 create/update workflow #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create/update workflow
LetItRock
requested review from
SokratisVidros,
scopsy,
ChmaraX and
djabarovgeorge
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
commented
Jan 7, 2025
Comment on lines
+119
to
+121
| (process.env.NOVU_ENTERPRISE === 'true' || | ||
| process.env.CI_EE_TEST === 'true') && | ||
| storedWorkflow.origin === WorkflowOriginEnum.NOVU_CLOUD_V1 |
There was a problem hiding this comment.
only run the translation analytics code in v1
There was a problem hiding this comment.
Ideally, we should not load the translations during the message sent in the SendMessageBase usecase, but I haven't added any logic there because there is no workflow information at that stage, like the NotificationStepEntity is missing the workflow info and particularly the origin field.
To do that, it might require more work.
SokratisVidros
approved these changes
Jan 7, 2025
LetItRock
deleted the
nv-5145-translation-groups-causing-long-response-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
The Translation Groups (TranslationService) are causing slow response time. The translations code is not relevant in v2.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer