Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Digest liquid helper and popover handler #7439

Open
wants to merge 6 commits into
base: pills-for-all-inputs
Choose a base branch
from

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Jan 6, 2025

What changed? Why was the change needed?

  • adds a digest modifier name
  • Adds suggested transformers section based on variable name suggestions

Screenshots

CleanShot 2025-01-06 at 16 45 39@2x

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitz

npm i https://pkg.pr.new/novuhq/novu/@novu/framework@7439
npm i https://pkg.pr.new/novuhq/novu@7439

commit: 43bbbaa

@scopsy scopsy marked this pull request as ready for review January 6, 2025 14:46
* {{ users | digest: 2, "name" }} => For array of {name: string}
* {{ users | digest: 2, "profile.name", "•" }} => "John • Josh and 3 others"
*/
export function digest(array: unknown, maxNames = 2, keyPath?: string, separator = ', '): string {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that's the best name 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant