chore(application-generic): Modernize app generic #7424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Got to its latest version to get all fixes and use its timing reporting so as to investigate timeouts with Bridge endpoints
- Convert it to ESM module - Replace jest with vitest - Restore all failing unit tests
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+186
to
+189
| const res = await request(url, { | ||
| ...options, | ||
| headers, | ||
| }).json(); | ||
| }); |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 19 days ago
To fix the SSRF vulnerability, we need to ensure that the bridgeUrl is validated against a whitelist of allowed URLs or domains. This can be done by checking if the bridgeUrl matches a predefined set of allowed URLs or domains before using it in the HTTP request.
- Introduce a whitelist of allowed URLs or domains.
- Validate the
bridgeUrlagainst this whitelist. - If the
bridgeUrlis not in the whitelist, throw an error.
Suggested changeset
1
libs/application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
| @@ -124,3 +124,3 @@ | ||
| command.workflowOrigin, | ||
| command.statelessBridgeUrl, | ||
| this.validateBridgeUrl(command.statelessBridgeUrl), | ||
| command.action, | ||
| @@ -494,2 +494,17 @@ | ||
| } | ||
| private validateBridgeUrl(url: string): string { | ||
| const allowedUrls = [ | ||
| 'https://allowed-domain1.com', | ||
| 'https://allowed-domain2.com', | ||
| // Add more allowed URLs or domains here | ||
| ]; | ||
|
|
||
| const isValid = allowedUrls.some(allowedUrl => url.startsWith(allowedUrl)); | ||
|
|
||
| if (!isValid) { | ||
| throw new BadRequestException('Invalid bridge URL'); | ||
| } | ||
|
|
||
| return url; | ||
| } | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
SokratisVidros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer