Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): variable management for all editor fields #7379

Open
wants to merge 58 commits into
base: next
Choose a base branch
from

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Dec 25, 2024

What changed? Why was the change needed?

  • Add support for variables pill in the FieldEditor component
  • Replace all existing body and subject to use the field editor
  • Introduce a variable popover
  • Allow managing liquid syntax in a visual way
  • Reordering liquid filters and managing filter params

Screenshots

https://www.loom.com/share/cd1ec264b44249f88770d1ffe0d37727
Uploading CleanShot 2024-12-30 at 20.36.12@2x.png…
CleanShot 2024-12-30 at 20 36 29@2x

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 481607c
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/677cf0390b0e0a0008207912
😎 Deploy Preview https://deploy-preview-7379.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 481607c
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/677cf03af61023000854af65
😎 Deploy Preview https://deploy-preview-7379.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scopsy
Copy link
Contributor Author

scopsy commented Jan 3, 2025

@SokratisVidros I've improved some useMemo usecases, but other than that I couldn't notice any significant degradation compared to staging or prod. Let me know if you have some specific scenarios we might want to optimize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants