refactor(root): update after pr comments

novuhq · Jan 9, 2025 · de580e5 · de580e5
1 parent 525ff63
commit de580e5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/apps/api/src/app/workflows-v2/util/template-parser/liquid-parser.ts b/apps/api/src/app/workflows-v2/util/template-parser/liquid-parser.ts
@@ -7,9 +7,6 @@ const LIQUID_CONFIG = {
   greedy: false,
   catchAllErrors: true,
 } as const;
-const DOT_ANNOTATION_MARKDOWN_HREF =
-  // eslint-disable-next-line max-len
-  '<a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Property_accessors#dot_notation" target="_blank" rel="noopener noreferrer" style="text-decoration: underline">dot notation</a>';
 
 export type Variable = {
   /**
@@ -168,7 +165,7 @@ function extractProps(template: any): { valid: boolean; props: string[]; error?:
     return {
       valid: false,
       props: [],
-      error: `<span>Invalid variable name containing whitespaces. Variables must follow the ${DOT_ANNOTATION_MARKDOWN_HREF}</span>`,
+      error: 'Invalid variable name containing whitespaces. Variables must follow the dot notation',
     };
   }
 
@@ -191,8 +188,7 @@ function extractProps(template: any): { valid: boolean; props: string[]; error?:
     return {
       valid: false,
       props: [],
-      // eslint-disable-next-line max-len
-      error: `<span>Invalid variable name missing namespace. Variables must follow the ${DOT_ANNOTATION_MARKDOWN_HREF} (e.g. payload.${validProps[0]})</span>`,
+      error: `Invalid variable name missing namespace. Variables must follow the dot notation (e.g. payload.${validProps[0]})`,
     };
   }
 

diff --git a/apps/dashboard/src/components/primitives/form/form.tsx b/apps/dashboard/src/components/primitives/form/form.tsx
@@ -128,9 +128,7 @@ const FormMessagePure = React.forwardRef<
       {...props}
     >
       <span>{error ? <RiErrorWarningFill className="size-4" /> : <RiInformationFill className="size-4" />}</span>
-      <span className="mt-[1px] text-xs leading-4">
-        {typeof body === 'string' ? <span dangerouslySetInnerHTML={{ __html: body }} /> : body}
-      </span>
+      <span className="mt-[1px] text-xs leading-4">{body}</span>
     </p>
   );
 });