Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALPHA: Next RELEASE #84

Merged
merged 8 commits into from
Oct 14, 2023
Merged

ALPHA: Next RELEASE #84

merged 8 commits into from
Oct 14, 2023

Conversation

ryshu
Copy link
Collaborator

@ryshu ryshu commented Oct 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (be6817f) 100.00% compared to head (7d41972) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1617      1706   +89     
  Branches       110       117    +7     
=========================================
+ Hits          1617      1706   +89     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
novu/api/base.py 100.00% <100.00%> (ø)
novu/api/change.py 100.00% <100.00%> (ø)
novu/api/message.py 100.00% <100.00%> (ø)
novu/api/notification.py 100.00% <100.00%> (ø)
novu/api/notification_group.py 100.00% <100.00%> (ø)
novu/api/notification_template.py 100.00% <100.00%> (ø)
novu/api/subscriber.py 100.00% <100.00%> (ø)
novu/api/tenant.py 100.00% <100.00%> (ø)
novu/dto/__init__.py 100.00% <ø> (ø)
novu/dto/notification.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ryshu and others added 6 commits October 4, 2023 22:08
…nse (#87)

* fix(notification): list notifications should return a paginated response

* feat: add methods to stream API entites instead of using pagination (#88)
* Update bug_report.md

In the improved bug report, I've made several enhancements to provide a more detailed and structured description of the issue. Here's a summary of the changes:

Clear and Concise Description:

The description of the bug is clearer and more concise, stating that the current implementation has a bug causing unexpected behavior.
Detailed Steps to Reproduce:

The steps to reproduce the bug are provided in a numbered list, making it easy to follow and understand.
Expected Behavior:

There's a specific section explaining what the user or reporter expected to happen when performing the steps.
Screenshots:

There's a placeholder for attaching relevant screenshots, if available. Screenshots can provide visual context for better understanding.
Versions Information:

There's a section for specifying the versions of relevant software or libraries. This helps in reproducing the bug and understanding potential compatibility issues.
Additional Context:

There's a section for providing any extra information or context about the problem. This can include specific conditions, error messages, or related background information.
Note to Reviewers:

A note is added for reviewers to guide them on what to focus on when investigating the bug report.
These improvements aim to make the bug report more informative, structured, and actionable. This can lead to quicker and more accurate resolutions for the reported issue.

* Update CHANGELOG.md

This should resolve the issue with the codespell
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.15 to 1.26.17.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.15...1.26.17)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ryshu ryshu merged commit 1dac2a3 into main Oct 14, 2023
11 checks passed
@unicodeveloper
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants