Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style changes to conform to ruby code conventions. #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code style changes to conform to ruby code conventions. #22

wants to merge 2 commits into from

Conversation

mnbbrown
Copy link

@mnbbrown mnbbrown commented Jun 2, 2023 •
edited
Loading

This includes:

  • removing uneccessary return statements
  • removing usage of static class variables
  • adding .freeze to class constants
  • using the faraday authorisation plugin
  • identation
  • using attr_accessor instead of getter and setter methods.

Also add gc_ruboconfig to conform to GoCardless ruby standards :)

@mnbbrown
Code style changes to conform to ruby code conventions.
4120d07 
This includes:

- removing uneccessary return statements
- removing usage of static class variables
- adding .freeze to class constants
- using the faraday authorisation plugin
- identation
- using attr_accessor instead of getter and setter methods.
@mnbbrown mnbbrown force-pushed the refactor-ruby-standards-authorisation branch from e3ca5a4 to 4120d07 Compare June 2, 2023 19:37
@mnbbrown mnbbrown marked this pull request as ready for review June 8, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mnbbrown