Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code cleanup and refactoring #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bebra777228
Copy link
Contributor

Code Cleanup and Refactoring

What was done:

  • Removed unused imports
  • Removed or merged duplicate tests
  • Conducted minor refactoring

Details:

  • The tests test_cli_Vocals_output_name_argument and test_cli_Instrumental_output_name_argument were removed. This decision was made because the code already includes two tests for renaming all stems for Demucs and other architectures. Therefore, a separate test for individual stems was deemed redundant.
  • The test test_cli_use_autocast_argument was also removed, as an identical test already exists in the code.
  • The tests test_inverse_device_handling and test_inverse_output_shape were combined into a single function, test_inverse_stft, since they were performing the same action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant