Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KO #219

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added KO #219

wants to merge 3 commits into from

Conversation

Song-Junho97
Copy link

Hello! I have translated this project into Korean.

I hope it will be translated into more languages.

Song Junho and others added 2 commits December 15, 2024 00:01
Fix JSON file line break
Copy link

@woojunro woojunro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I suggested some subtle changes that might sound more native to Korean.
I really appreciate your work!

"Plural-Forms: nplurals=2; plural=(n != 1);\n"

msgid "header.subtitle"
msgstr "채팅에서 간단한 인사는 하지 마세요"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "채팅에서 간단한 인사는 하지 마세요"
msgstr "채팅에서 간단한 인사만 하지는 마세요"

Copy link
Author

@Song-Junho97 Song-Junho97 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion. Considering your opinion, I think "채팅에서 간단한 인사만 하지 마세요" sounds more natural.

locales/ko/messages.po Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants