Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: to_kebab_case(): trim illegal ms characters #143

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

Rabenherz112
Copy link
Contributor

When running a pull or clone operation on the awesome-selfhosted-data repository, it currently fails on Windows devices due to a file containing an invalid character for Windows file names.

This PR addresses the issue by adding the problematic character to the trim list. Additionally, it updates the list to include all other illegal characters for Windows file names to prevent similar issues in the future. (I am pretty sure we already had this issue some time ago.)

git clone https://github.com/awesome-selfhosted/awesome-selfhosted-data/
Cloning into 'awesome-selfhosted-data'...
remote: Enumerating objects: 399925, done.
remote: Counting objects: 100% (50785/50785), done.
remote: Compressing objects: 100% (2373/2373), done.
remote: Total 399925 (delta 49668), reused 48994 (delta 48412), pack-reused 349140 (from 1)Receiving objects: 100% (399925/399925), 38.14 MiB | 37.87 MiB/s
Receiving objects: 100% (399925/399925), 46.42 MiB | 38.30 MiB/s, done.
Resolving deltas: 100% (387299/387299), done.
error: invalid path 'software/what-to-cook?.yml'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

@nodiscc nodiscc added the bug Something isn't working label Dec 29, 2024
@nodiscc nodiscc merged commit e50a183 into nodiscc:master Dec 29, 2024
1 check failed
@Rabenherz112 Rabenherz112 deleted the enh-kebab_case branch December 29, 2024 17:53
nodiscc added a commit to awesome-selfhosted/awesome-selfhosted-data that referenced this pull request Dec 29, 2024
nodiscc added a commit to awesome-selfhosted/awesome-selfhosted-data that referenced this pull request Dec 29, 2024
* tools: update hecat to v1.3.1
- https://github.com/nodiscc/hecat/releases/tag/1.3.1
* fix what-to-cook?.yml filename preventing cloning on windows
- #1044
- nodiscc/hecat#143
Repository owner deleted a comment from Pjrich1313 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants