test_runner: print failing assertion only once with spec reporter #56662
+5
−782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Llorx <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56662 +/- ##
==========================================
+ Coverage 89.19% 89.22% +0.02%
==========================================
Files 662 662
Lines 191893 191895 +2
Branches 36937 36943 +6
==========================================
+ Hits 171164 171221 +57
+ Misses 13573 13521 -52
+ Partials 7156 7153 -3
|
legendecas
approved these changes
Jan 23, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Jan 24, 2025
pmarchini
added
the
author ready
jasnell
approved these changes
Jan 24, 2025
jasnell
pushed a commit
that referenced
this pull request
Jan 24, 2025
Co-authored-by: Llorx <[email protected]> PR-URL: #56662 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in c752615 |
|
Just a note - I just had my first experience really using the test runner after this change landed. It's really nice 👍 |
aduh95
pushed a commit
that referenced
this pull request
Jan 27, 2025
Co-authored-by: Llorx <[email protected]> PR-URL: #56662 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 30, 2025
Co-authored-by: Llorx <[email protected]> PR-URL: #56662 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
hvanness
pushed a commit
to hvanness/node
that referenced
this pull request
Jan 30, 2025
Co-authored-by: Llorx <[email protected]> PR-URL: nodejs#56662 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address #56316.
I've opened this PR because #56351 seems stale.
Considering that @Llorx would be a first-time contributor finalising his PR (which was missing only updates to the tests), I'd suggest waiting a few days before landing this one, giving him more time 🚀
I've added @Llorx as a co-author of the commit