sqlite: add aggregate function #56600
Draft
+128
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
targos
reviewed
Jan 20, 2025
Comment on lines
72
to
+74
| V(ack_string, "ack") \ | ||
| V(step_string, "step") \ | ||
| V(start_string, "start") \ |
There was a problem hiding this comment.
These should be ordered alphabetically
jasnell
reviewed
Jan 20, 2025
| Local<Object> options = args[1].As<Object>(); | ||
| Local<Value> step_v; | ||
| if (!options->Get(env->context(), env->step_string()).ToLocal(&step_func)) { | ||
| // TODO: throw an error; step is required |
There was a problem hiding this comment.
If Get returns nothing and this is false, then v8 should already be scheduling an error to be thrown. There shouldn't be a need to throw another error.
There was a problem hiding this comment.
Oh, great! Thanks for letting me know!
cjihrig
reviewed
Jan 20, 2025
| : env_(env), fn_(env->isolate(), fn) {} | ||
|
|
||
| static void xStep(sqlite3_context* ctx, int argc, sqlite3_value** argv) {} | ||
|
|
There was a problem hiding this comment.
Style nit: can you remove the extra blank lines.
Comment on lines
+701
to
+702
| // database.aggregate(name, { start, step, inverse, result, directOnly, | ||
| // deterministic, varargs }) |
There was a problem hiding this comment.
Suggested change
| // database.aggregate(name, { start, step, inverse, result, directOnly, | |
| // deterministic, varargs }) |
|
Also, tests and docs are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56511
inspired by https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#aggregatename-options---this