Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: expose CallSite.scriptId #56551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

util: expose CallSite.scriptId #56551

wants to merge 1 commit into from
+17 −0

Conversation

legendecas
Copy link
Member

The scriptId is essential to construct chrome devtools protocol
structs like Network.Initiator, allowing inspectors to associate
a CallSite with a unique script.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 10, 2025
@legendecas
util: expose CallSite.scriptId
2213edc 
The `scriptId` is essential to construct chrome devtools protocol
structs like `Network.Initiator`, allowing inspectors to associate
a `CallSite` with a unique script.
@legendecas legendecas force-pushed the util/callsites-scriptid branch from e28331e to 2213edc Compare January 10, 2025 14:56
@BridgeAR BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64432/

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (19c8cc1) to head (2213edc).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56551      +/-   ##
==========================================
+ Coverage   89.16%   89.17%   +0.01%     
==========================================
  Files         662      662              
  Lines      191745   191754       +9     
  Branches    36902    36903       +1     
==========================================
+ Hits       170971   171003      +32     
- Misses      13627    13632       +5     
+ Partials     7147     7119      -28
Files with missing lines Coverage Δ
src/node_util.cc 85.93% <100.00%> (+0.16%) ⬆️

... and 40 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @nodejs-github-bot @BridgeAR