Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use non-deprecated ares_set_servers_csv API #56451

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

targos
Copy link
Member

@targos targos commented Jan 3, 2025

Refs: #52464

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Jan 3, 2025
@targos
Copy link
Member Author

targos commented Jan 3, 2025

@nodejs/cpp-reviewers

src/cares_wrap.cc Outdated Show resolved Hide resolved
Co-authored-by: Yagiz Nizipli <[email protected]>
@targos targos marked this pull request as draft January 3, 2025 15:50
@targos
Copy link
Member Author

targos commented Jan 3, 2025

=== release test-dns ===
Path: parallel/test-dns
Error: --- stderr ---
node:assert:127
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
    '4.4.4.4',
    '2001:4860:4860::8888',
    '103.238.225.181:666',
-   '[fe80::483a:5aff:fee6:1f04]:666',
-   'fe80::483a:5aff:fee6:1f04'
  ]

    at Object.<anonymous> (/home/runner/work/node/node/node/test/parallel/test-dns.js:137:8)
    at Module._compile (node:internal/modules/cjs/loader:1739:14)
    at Object..js (node:internal/modules/cjs/loader:1904:10)
    at Module.load (node:internal/modules/cjs/loader:1473:32)
    at Function._load (node:internal/modules/cjs/loader:1285:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:234:24)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:151:5)
    at node:internal/main/run_main_module:33:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [ '4.4.4.4', '2001:4860:4860::8888', '103.238.225.181:666' ],
  expected: [
    '4.4.4.4',
    '2001:4860:4860::8888',
    '103.238.225.181:666',
    '[fe80::483a:5aff:fee6:1f04]:666',
    'fe80::483a:5aff:fee6:1f04'
  ],
  operator: 'deepStrictEqual'
}

Node.js v24.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /home/runner/work/node/node/node/test/parallel/test-dns.js

I didn't get this failure locally (ran tools/test.py dns).

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (bf3bc4e) to head (75c4298).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56451      +/-   ##
==========================================
- Coverage   88.54%   88.50%   -0.04%     
==========================================
  Files         657      657              
  Lines      190765   190759       -6     
  Branches    36611    36602       -9     
==========================================
- Hits       168908   168832      -76     
- Misses      15036    15124      +88     
+ Partials     6821     6803      -18     
Files with missing lines Coverage Δ
src/cares_wrap.cc 60.72% <100.00%> (-4.52%) ⬇️

... and 34 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants