test: update test-set-http-max-http-headers to use node:test #56439
+8
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56439 +/- ##
=======================================
Coverage 88.53% 88.54%
=======================================
Files 657 657
Lines 190741 190741
Branches 36607 36605 -2
=======================================
+ Hits 168881 168887 +6
+ Misses 15036 15031 -5
+ Partials 6824 6823 -1 |
This commit updates test/parallel/test-set-http-max-http-headers.js to use node:test. This test already implemented a test runner, so it makes sense to use the existing public API.
cjihrig
force-pushed
the
max-header-test
branch
from
49c513a to
23de839
Compare
anonrig
approved these changes
Jan 3, 2025
anonrig
approved these changes
Jan 3, 2025
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jan 3, 2025
cjihrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 221040b |
targos
pushed a commit
that referenced
this pull request
Jan 13, 2025
This commit updates test/parallel/test-set-http-max-http-headers.js to use node:test. This test already implemented a test runner, so it makes sense to use the existing public API. PR-URL: #56439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Jan 13, 2025
This commit updates test/parallel/test-set-http-max-http-headers.js to use node:test. This test already implemented a test runner, so it makes sense to use the existing public API. PR-URL: nodejs#56439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates test/parallel/test-set-http-max-http-headers.js to use node:test. This test already implemented a test runner, so it makes sense to use the existing public API.