-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test reporter #56438
base: main
Are you sure you want to change the base?
Test reporter #56438
Conversation
This commit introduces a node:test reporter to the common utils. This reporter can be used to silence output other than errors from node:test. This is useful because in Node's own test suite, the output of node:test is included in the output of the Python test runner. Refs: nodejs#49120
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56438 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01%
==========================================
Files 657 657
Lines 190741 190741
Branches 36607 36610 +3
==========================================
+ Hits 168881 168906 +25
+ Misses 15036 15007 -29
- Partials 6824 6828 +4 |
I kept the failing test so the output can be seen. I will remove it once we agree that output is good enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, this seems fine to me. We can also iterate on it pretty quickly since it's internal only. I'm not sure if I can sign off on this or not since I'm the original author, but throwing my LGTM here.
Also, we'll have to remove that intentional failure before landing.
On a side note, I definitely think we (you?) should open another PR to get rid of the GitHub reporter. It generates far too much output noise.
Sure, I can open the PR |
Building on top of #52189
Rebased with main to fix conflicts and added
FAIL_FAST
envvar.cc @cjihrig @JakobJingleheimer