Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reporter #56438

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Test reporter #56438

wants to merge 4 commits into from

Conversation

Ceres6
Copy link
Contributor

@Ceres6 Ceres6 commented Jan 2, 2025

Building on top of #52189

This commit introduces a node:test reporter to the common utils. This reporter can be used to silence output other than errors from node:test. This is useful because in Node's own test suite, the output of node:test is included in the output of the Python test runner.

Refs: #49120

Rebased with main to fix conflicts and added FAIL_FAST envvar.

cc @cjihrig @JakobJingleheimer

This commit introduces a node:test reporter to the common utils.
This reporter can be used to silence output other than errors
from node:test. This is useful because in Node's own test suite,
the output of node:test is included in the output of the
Python test runner.

Refs: nodejs#49120
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (98d4ebc) to head (d34f649).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56438      +/-   ##
==========================================
+ Coverage   88.53%   88.55%   +0.01%     
==========================================
  Files         657      657              
  Lines      190741   190741              
  Branches    36607    36610       +3     
==========================================
+ Hits       168881   168906      +25     
+ Misses      15036    15007      -29     
- Partials     6824     6828       +4     

see 26 files with indirect coverage changes

@Ceres6
Copy link
Contributor Author

Ceres6 commented Jan 3, 2025

I kept the failing test so the output can be seen. I will remove it once we agree that output is good enough

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, this seems fine to me. We can also iterate on it pretty quickly since it's internal only. I'm not sure if I can sign off on this or not since I'm the original author, but throwing my LGTM here.

Also, we'll have to remove that intentional failure before landing.

On a side note, I definitely think we (you?) should open another PR to get rid of the GitHub reporter. It generates far too much output noise.

@Ceres6
Copy link
Contributor Author

Ceres6 commented Jan 4, 2025

Sure, I can open the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants