test_runner: add assert.register() API #56434
Merged
+166
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Jan 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56434 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 657 658 +1
Lines 190761 190807 +46
Branches 36616 36619 +3
==========================================
+ Hits 168899 168939 +40
+ Misses 15048 15044 -4
- Partials 6814 6824 +10
|
cjihrig
added
the
semver-minor
This commit adds a top level assert.register() API to the test runner. This function allows users to define their own custom assertion functions on the TestContext. Fixes: nodejs#52033
cjihrig
added
request-ci
I think this is as close as we will get to that request. This allows assertions to be created that don't throw. IMO it also doesn't make sense to add logic to EDIT: Actually, I think we need to add a |
github-actions
bot
removed
the
request-ci
cjihrig
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56434 ✔ Done loading data for nodejs/node/pull/56434 ----------------------------------- PR info ------------------------------------ Title test_runner: add assert.register() API (#56434) Author Colin Ihrig <[email protected]> (@cjihrig) Branch cjihrig:asserts -> nodejs:main Labels semver-minor, author ready, commit-queue-squash, test_runner Commits 2 - test_runner: add assert.register() API - nits Committers 1 - cjihrig <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56434 Fixes: https://github.com/nodejs/node/issues/52033 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56434 Fixes: https://github.com/nodejs/node/issues/52033 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Pietro Marchini <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test_runner: add assert.register() API ⚠ - nits ℹ This PR was created on Thu, 02 Jan 2025 13:27:50 GMT ✔ Approvals: 3 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/56434#pullrequestreview-2528217838 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/56434#pullrequestreview-2528251814 ✔ - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/56434#pullrequestreview-2528681830 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-03T23:12:12Z: https://ci.nodejs.org/job/node-test-pull-request/64326/ - Querying data for job/node-test-pull-request/64326/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12610900600 |
|
This needs another approval or a re-approval in order to land. |
pmarchini
approved these changes
Jan 4, 2025
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4a7b815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a top level
assert.register()API to the test runner. This function allows users to define their own custom assertion functions on the TestContext.Fixes: #52033