Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove more forcefully #3113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove more forcefully #3113

wants to merge 1 commit into from

Conversation

tmm1
Copy link

@tmm1 tmm1 commented Dec 31, 2024

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

on some linux machines, i observed:

npm error gyp http fetch GET https://artifacts.electronjs.org/headers/v30.5.1/node-v30.5.1-headers.tar.gz?force_headers_dist=1 attempt 1 failed with ETIMEDOUT
npm error gyp WARN install got an error, rolling back install
npm error gyp ERR! configure error
npm error gyp ERR! stack Error: ENOTEMPTY: directory not empty, rmdir '/home/AzDevOps/.cache/node-gyp/30.5.1/include/node'

(side note: i'm not sure why the http fetch is not being retried, or where the "attempt 1" comes from)

unfortunately this leaves the system in a broken state, as a subsequent retries (with my own loop around npm) all fail:

npm failed 1, trying again...
...
npm error gyp WARN read config.gypi ENOENT: no such file or directory, open '/home/AzDevOps/.cache/node-gyp/30.5.1/include/node/config.gypi'

this is apparently a known and documented issue. i have implemented the recommended workaround in this PR.

@cclauss
Copy link
Contributor

cclauss commented Dec 31, 2024

macOS on Intel seems to fail but macOS on ARM seems to always pass.

I got the same CI test results with unrelated changes on #3114

@tmm1
Copy link
Author

tmm1 commented Dec 31, 2024

ironically it seems similar to the issue i described here. there must be another fs.rm somewhere that needs retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants