New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lookup: on-finished #1073

Merged

targos merged 1 commit into nodejs:main from bjohansebas:on-finished

Dec 23, 2024

Contributor

bjohansebas commented Dec 6, 2024 •

edited

Loading

Checklist

npm test passes
tests are included
documentation is changed or added
contribution guidelines followed
here

The on-finished module is added, and it doesn't show any failures locally.

Fixed: #803


          lookup: on-finished

0a703cc

UlisesGascon approved these changes

View reviewed changes

Member

UlisesGascon left a comment

cc: @wesleytodd

Member

RafaelGSS commented Dec 23, 2024

We should run the CITGM for it before merging.

Member

targos commented Dec 23, 2024 •

edited

Loading

First test on limited platforms: https://github.com/nodejs/citgm/actions/runs/12467905870 ✅

Member

targos commented Dec 23, 2024 •

edited

Loading

Jenkins CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/268/ ✅

targos approved these changes

View reviewed changes

targos merged commit 1db6dff into nodejs:main

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet