Re-enable readable-stream

[mcollina]

#1037

Checklist

• npm test passes
• tests are included
• documentation is changed or added
• contribution guidelines followed
  here

[mcollina]

GH Action run: https://github.com/nodejs/citgm/actions/runs/7219998821

[mcollina]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3360/

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2a0731) 95.23% compared to head (67aa775) 95.23%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          28       28           
  Lines        2181     2181           
=======================================
  Hits         2077     2077           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[targos]

Looks broken on v21.

[mcollina]

working on it in nodejs/readable-stream#528, hopefully landing soon.

[richardlau]

Installation fails on AIX as esbuild doesn't support it.

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3360/nodes=aix72-ppc64/console

09:34:22 warn: readable-stream npm-install:| npm ERR! code 1                                                                                                                                                        
09:34:22 warn:                             | npm ERR! path /home/iojs/tmp/citgm_tmp/cd2c8a76-4c62-439c-840f-095946746320/readable-stream/node_modules/esbuild                                                       
09:34:22 warn:                             | npm ERR! command failed                                                                                                                                                
09:34:22 warn:                             | npm ERR! command sh -c node install.js                                                                                                                                 
09:34:22 warn:                             | npm ERR! /home/iojs/tmp/citgm_tmp/cd2c8a76-4c62-439c-840f-095946746320/readable-stream/node_modules/esbuild/install.js:69                                              
09:34:22 warn:                             | npm ERR!     throw new Error(`Unsupported platform: ${platformKey}`);                                                                                                  
09:34:22 warn:                             | npm ERR!           ^                                                                                                                                                   
09:34:22 warn:                             | npm ERR!                                                                                                                                                               
09:34:22 warn:                             | npm ERR! Error: Unsupported platform: aix ppc64 BE                                                                                                                     
09:34:22 warn:                             | npm ERR!     at pkgAndSubpathForCurrentPlatform (/home/iojs/tmp/citgm_tmp/cd2c8a76-4c62-439c-840f-095946746320/readable-stream/node_modules/esbuild/install.js:69:11)  
09:34:22 warn:                             | npm ERR!     at checkAndPreparePackage (/home/iojs/tmp/citgm_tmp/cd2c8a76-4c62-439c-840f-095946746320/readable-stream/node_modules/esbuild/install.js:211:28)          
09:34:22 warn:                             | npm ERR!     at Object.<anonymous> (/home/iojs/tmp/citgm_tmp/cd2c8a76-4c62-439c-840f-095946746320/readable-stream/node_modules/esbuild/install.js:238:1)               
09:34:22 warn:                             | npm ERR!     at Module._compile (node:internal/modules/cjs/loader:1375:14)                                                                                             
09:34:22 warn:                             | npm ERR!     at Module._extensions..js (node:internal/modules/cjs/loader:1434:10)                                                                                      
09:34:22 warn:                             | npm ERR!     at Module.load (node:internal/modules/cjs/loader:1206:32)                                                                                                 
09:34:22 warn:                             | npm ERR!     at Module._load (node:internal/modules/cjs/loader:1022:12)                                                                                                
09:34:22 warn:                             | npm ERR!     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:142:12)                                                                    
09:34:22 warn:                             | npm ERR!     at node:internal/main/run_main_module:28:49                                                                                                               
09:34:22 warn:                             | npm ERR!                                                                                                                                                               
09:34:22 warn:                             | npm ERR! Node.js v22.0.0-pre                                                                                                                                           
09:34:22 warn:                             |                                                                                                                                                                        
09:34:22 warn:                             | npm ERR! A complete log of this run can be found in: /home/iojs/tmp/citgm_tmp/cd2c8a76-4c62-439c-840f-095946746320/home/.npm/_logs/2023-12-15T09_44_41_045Z-debug-0.log

[merceyz]

@richardlau I opened an issue in the esbuild repo about adding aix ppc64 BE support, do you think it would be possible to test if it works on that machine?

Ref evanw/esbuild#3549 (comment)

[mcollina]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3363/

[mcollina]

GHA: https://github.com/nodejs/citgm/actions/runs/7219998821

[mcollina]

It seems it's passing on Linux. Why is it run on aix and windows even if it's skipped in the definition? https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3363/nodes=aix72-ppc64/testReport/junit/(root)/citgm/readable_stream_v4_5_0/

[targos]

Skips only apply to the citgm-all command.

[mcollina]

@RafaelGSS @richardlau what's the next step here?

[RafaelGSS]

@RafaelGSS @richardlau what's the next step here?

If that's passing in the expected environments we can merge it and release a new version.

[richardlau]

@richardlau I opened an issue in the esbuild repo about adding aix ppc64 BE support, do you think it would be possible to test if it works on that machine?

Ref evanw/esbuild#3549 (comment)

@merceyz I've asked @abmusse from IBM to take a look.

[mcollina]

Note that the esbuild package is not strictly needed to run those tests, but I'm not sure how I can skip its install at this stage.

[abmusse]

@richardlau I opened an issue in the esbuild repo about adding aix ppc64 BE support, do you think it would be possible to test if it works on that machine?
Ref evanw/esbuild#3549 (comment)

@merceyz I've asked @abmusse from IBM to take a look.

UPDATE

I've tested installing the current latest version of [email protected] on AIX 7.2 and the install was successful.

Ref: evanw/esbuild#3549 (comment)

[mcollina]

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3372/

[mcollina]

Should be good to go if the run pass. What are the next steps?