lib: log correct version and sha for -c option #1026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation here is to fix misleading version output when using the
-c
option.Note that
[email protected] test
is what was run as expected (corresponding to MylesBorins/omg-i-pass@37c34ba) but CITGM reports it as latest:info: version: | 3.0.0
.With this change:
I also added
info: sha: | 37c34bad
as extra log information only when using the-c
option because it's possible multiple commits will reference the same version, and the explicit debug information seems like it would be useful.This was a bit of a 🐰 🕳️ so if anyone has a better suggestion for how to correct this feel free 🙂
Checklist
npm test
passeshere