chore: remove torrent-stream #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 4, 2023
richardlau
approved these changes
Oct 4, 2023
richardlau
reviewed
Oct 4, 2023
Removing `torrent-stream` from lib/lookup.json since it has been failing regularly on both `v18.x` and `v20.x` release lines due to a timeout. Refs: nodejs#1000
ruyadorno
force-pushed
the
flaky-torrent-stream
branch
from
6fc1aaf to
b8e0ca6
Compare
ruyadorno
changed the title
|
heads up @richardlau I updated the PR to remove |
targos
approved these changes
Oct 4, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76 ☔ View full report in Codecov by Sentry. |
richardlau
approved these changes
Oct 4, 2023
Closed
RafaelGSS
approved these changes
Oct 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
torrent-streamfrom lib/lookup.json since it has been failingregularly on both
v18.xandv20.xrelease lines due to a timeout.Refs: #1000