Add GitHub Actions CI support.

[XhmikosR]

1. this requires Update all dependencies #61 for the lock file addition. If you guys don't want a lockfile, I can change this to just use npm i
2. I don't know what exactly is required for tests to run. A token?
3. I also plan to add Windows testing later -- DONE, but I might need to drop it from here and tackle it later separately

[XhmikosR]

Alright, let's focus on getting this up and running.

I untied this patch from #61. I have added Ubuntu only and I'm using npm install for starters.

[XhmikosR]

If someone could add the needed secrets on the repo secrets page, let me know what names you used and I'll adapt the patch so that it uses them when running tests.

[rvagg]

according to https://help.github.com/en/articles/virtual-environments-for-github-actions#github_token-secret we might be able to make use of GITHUB_TOKEN. You'll need to do this in the action:

    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Then if you can run some bash before running the tests, try this (for Linux):

mkdir -p .config/changelog-maker/ && echo '{"user":"nodejs","token":"'${GITHUB_TOKEN}'"}' > .config/changelog-maker/config.json

The awkward bit is the "user", I'm not sure whether it matters. It gets combined with the token for the Authorization: Basic <base64 of user:token> header (see https://github.com/rvagg/ghutils/blob/master/ghutils.js#L13). I don't see what user GITHUB_TOKEN is associated with or even whether it matters.

[XhmikosR]

Alright, GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" doesn't seem to work.

We need to add and pass the exact variables including the user.

[rvagg]

if that doesn't work, the alternatives i see are: (1) generate a token for an account owned by the org or (2) modify ghutils to directly use the Authorization: token <token> header. I'm unclear about whether this will break existing use of ghutils but we could probably find out.

[rvagg]

@XhmikosR you need to do something with GITHUB_TOKEN, see the bash I put in that previous comment to put it into a config file that's picked up by ghauth.

[rvagg]

       - run: mkdir -p .config/changelog-maker/ && echo '{"user":"nodejs","token":"'${GITHUB_TOKEN}'"}' > .config/changelog-maker/config.json
       - run: npm test

?

[XhmikosR]

@rvagg does ghauth pick up user variables about user and token or does it need a config explicitly?

I will try this later, but I'm on Windows currently.

[rvagg]

@XhmikosR it picks it up from a config file that looks like {"user":"foo","token":"bar"}. It should be created on Windows @ %LOCALAPPDATA%/changelog-maker/config.json (as per https://github.com/LinusU/node-application-config#config-location). When you first invoke ghauth (see collect-commit-labels.js) and you don't have this file, it should prompt you on the commandline to enter github credentials and it'll make a token for you and save it to that file for future use.

[XhmikosR]

@rvagg so as things are right now, we need tho create these configs. Would it be possible to make ghauth use env vars too? I think it would simplify things a lot.

Regardless, I'll experiment with this and let you know how it goes.

[rvagg]

Would it be possible to make ghauth use env vars too

yes, it would certainly simplify the CI case .. I'm not sole maintainer so any such PR will need discussion.

[XhmikosR]

It works! The path is ~/.config/changelog-maker/config.json.

[XhmikosR]

Only thing I don't know is if this will work for forks. I guess we'll find out later.

/CC @targos for a quick review too :)

[XhmikosR]

I added Windows too. I don't think the shell used on Windows demonstrates the failures I had locally, though, because CI is passing even with the old gitexec.

That being said, this should better than nothing.

[rvagg]

nice work!

[targos]

Nice!