-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post new learn resources about "package publish" #44
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Is "We gotchu" too colloquial (difficult for ESL users)? Should it be "We got you"? |
Co-authored-by: Jacob Smith <[email protected]>
Any strong opinion on that. Because blue sky have an integrated translation feature (google translate) and I had test with "we gotchu" and it's translate correctly. And also I think we need to be familiar instead of corporate |
Sweet! Looks like no problem then 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the guidelines https://github.com/nodejs/bluesky/blob/main/review_guidelines.md it seems only release annoucements are allowed. Let me check if documentation needs to be updated. (I see other things have been reposted so apparently the documentation is wrong)
Apparently its ok to repost articles
I didn't know this either, and have been asking for many reposts. agree we should update |
@nodejs/bluesky can we process for this pr ? |
re ping @nodejs/bluesky |
The article itself doesn't seem to be ready as a definitive guide for package publishing, I've seem some package maintainers discussing the usage of exports field for various special needs outside what's described in that article (e.g. patterns used by https://github.com/privatenumber/pkgroll). It would be better to be sent as an invitation for further improvement on this guide instead of saying "we gotchu" which implies it's everything you will need. |
That is a good point: it is not in its final form (ex 2 items down my todo list is splitting this article into 2: basic and exotic configs). Happy to re-word. |
Co-authored-by: Jacob Smith <[email protected]>
#36