Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post new learn resources about "package publish" #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AugustinMauroy
Copy link
Member

#36

@github-actions github-actions bot added the action-request Request to perform actions on bluesky accounts label Dec 22, 2024
@AugustinMauroy AugustinMauroy changed the title Create nodejs-learn-package-publish.json post new learn ressources about "package publish" Dec 22, 2024
@AugustinMauroy
Copy link
Member Author

cc @JakobJingleheimer

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

records/new/nodejs-learn-package-publish.json Outdated Show resolved Hide resolved
@JakobJingleheimer
Copy link
Member

Is "We gotchu" too colloquial (difficult for ESL users)? Should it be "We got you"?

@AugustinMauroy
Copy link
Member Author

Is "We gotchu" too colloquial (difficult for ESL users)? Should it be "We got you"?

Any strong opinion on that. Because blue sky have an integrated translation feature (google translate) and I had test with "we gotchu" and it's translate correctly.

And also I think we need to be familiar instead of corporate

@JakobJingleheimer
Copy link
Member

blue sky have an integrated translation feature (google translate) and I had test with "we gotchu" and it's translate correctly

Sweet! Looks like no problem then 😃

Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the guidelines https://github.com/nodejs/bluesky/blob/main/review_guidelines.md it seems only release annoucements are allowed. Let me check if documentation needs to be updated. (I see other things have been reposted so apparently the documentation is wrong)

@marco-ippolito marco-ippolito dismissed their stale review December 22, 2024 19:35

Apparently its ok to repost articles

@bmuenzenmeyer
Copy link
Contributor

From the guidelines https://github.com/nodejs/bluesky/blob/main/review_guidelines.md it seems only release annoucements are allowed. Let me check if documentation needs to be updated. (I see other things have been reposted so apparently the documentation is wrong)

I didn't know this either, and have been asking for many reposts. agree we should update

@AugustinMauroy
Copy link
Member Author

@nodejs/bluesky can we process for this pr ?

@AugustinMauroy
Copy link
Member Author

re ping @nodejs/bluesky

@joyeecheung
Copy link
Member

The article itself doesn't seem to be ready as a definitive guide for package publishing, I've seem some package maintainers discussing the usage of exports field for various special needs outside what's described in that article (e.g. patterns used by https://github.com/privatenumber/pkgroll). It would be better to be sent as an invitation for further improvement on this guide instead of saying "we gotchu" which implies it's everything you will need.

@JakobJingleheimer
Copy link
Member

The article itself doesn't seem to be ready as a definitive guide for package publishing, I've seem some package maintainers discussing the usage of exports field for various special needs outside what's described in that article (e.g. patterns used by https://github.com/privatenumber/pkgroll). It would be better to be sent as an invitation for further improvement on this guide instead of saying "we gotchu" which implies it's everything you will need.

That is a good point: it is not in its final form (ex 2 items down my todo list is splitting this article into 2: basic and exotic configs).

Happy to re-word.

@marco-ippolito marco-ippolito changed the title post new learn ressources about "package publish" post new learn resources about "package publish" Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action-request Request to perform actions on bluesky accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants