Fix a data race and add a CMake TSan option. #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit Jacob <[email protected]>
ScottTodd
reviewed
Jan 20, 2025
| add_compile_definitions(IREE_SANITIZER_ADDRESS) | ||
| endif() | ||
|
|
||
| option(SHORTFIN_ENABLE_TSAN "Enable TSAN" OFF) |
There was a problem hiding this comment.
Can you add a note here advertising the TSAN option too?
Lines 146 to 148 in 26bb250
There was a problem hiding this comment.
I haven't tried to run anything else than ctest so I have no experience with Python so I wouldn't know what to write here.... can I just defer to you in a follow-up?
There was a problem hiding this comment.
Ah, fair. That is Python-specific and does also rely on this plumbing:
Line 228 in 26bb250
I was mainly looking for any developer docs we have that mention ASan, since they could also mention TSan and other sanitizers too.
Fine to just add the option to CMake for now.
ScottTodd
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ bit solves a data race reported by TSan, see #847.
The CMake bit mimics what exists for ASAN and removes an incorrect
# Enable more ASAN checkscomment. TheIREE_SANITIZER_are used in core logic to check against mismatches between the IREE runtime and the libraries it loads.https://github.com/iree-org/iree/blob/db129e500f35ead4debc363eb15ebfb929ee512b/runtime/src/iree/hal/local/loaders/system_library_loader.c#L168-L178
Fixes #847