Use a minimal error mask for CAN communication to avoid stopping on i… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nformative messages
|
Agreed, but rather than merging this I would like to point the target to this branch. More explicit because otherwise we have a different melodic branch from the forked repo which might be confusing. |
|
Agreed, I'll change our targets where appropriate. |
|
Solved by ros-industrial#362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed, this seems to be the minimal viable error mask to use. Other error-frames are more of the informative kind.
CAN_ERR_BUSOFF, CAN_ERR_BUSERROR and CAN_ERR_RESTARTED are critical errors. Only CAN_ERR_BUSERROR may flood, so better to leave that one out as well.